Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 2.0
    • Component/s: Gradebook
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      35215

      Description

      At present each module adds own grading settings into mod_edit form, solution of many problems is to standardize this by using new plugin_supports function.
      This will allow us to put all needed grade item settings without the need to synchronize module and gradebook settings.

      We also need a way to synchronise grade item hidden flag with module show option.

        Issue Links

          Activity

          Hide
          Andrew Davis added a comment -
          Show
          Andrew Davis added a comment - First draft of spec is here. http://docs.moodle.org/en/Development:Grade_settings_modules
          Hide
          Andrew Davis added a comment -

          I've made a lot of additions to the document. I think it more or less spells out the implementation. The changes necessary to the assignment module are described fairly explicitly. The changes that will be required for the quiz module are less clear.

          Show
          Andrew Davis added a comment - I've made a lot of additions to the document. I think it more or less spells out the implementation. The changes necessary to the assignment module are described fairly explicitly. The changes that will be required for the quiz module are less clear.
          Hide
          Andrew Davis added a comment - - edited

          If I'm understanding the task I think the document is more or less done. I have previously not fully understood what I am to do so please speak up if the document isn't correct

          Show
          Andrew Davis added a comment - - edited If I'm understanding the task I think the document is more or less done. I have previously not fully understood what I am to do so please speak up if the document isn't correct
          Hide
          Andrew Davis added a comment - - edited

          I've reshuffled some forms code so that the grades fields are output by moodleform rather than by the modules themselves. A patch is attached for discussion and review.

          Note that I have not yet refactored the assignment.grade column as outlined at http://docs.moodle.org/en/Development:Grade_settings_modules#Module_Enhancements

          Show
          Andrew Davis added a comment - - edited I've reshuffled some forms code so that the grades fields are output by moodleform rather than by the modules themselves. A patch is attached for discussion and review. Note that I have not yet refactored the assignment.grade column as outlined at http://docs.moodle.org/en/Development:Grade_settings_modules#Module_Enhancements
          Hide
          Andrew Davis added a comment -

          Committed some changes. At one point I had standard_coursemodule_elements() call standard_grading_coursemodule_elements(). That meant that individual modules just had to say they supported grades and the grade element would appear automatically.

          The problem was that the module has no control of the order of the settings. If standard_coursemodule_elements() inserts the grade settings then they will always appear appear above "Common module settings". This was particularly a problem for the lesson module. It has some other kind of grade related settings like Display ongoing score and allow retakes that it has titled "Grade options". Having "Grade options" near the top and then "Grade" near the bottom just looked wrong. Alternatively I could rename that block something like "Attempt options"...

          Show
          Andrew Davis added a comment - Committed some changes. At one point I had standard_coursemodule_elements() call standard_grading_coursemodule_elements(). That meant that individual modules just had to say they supported grades and the grade element would appear automatically. The problem was that the module has no control of the order of the settings. If standard_coursemodule_elements() inserts the grade settings then they will always appear appear above "Common module settings". This was particularly a problem for the lesson module. It has some other kind of grade related settings like Display ongoing score and allow retakes that it has titled "Grade options". Having "Grade options" near the top and then "Grade" near the bottom just looked wrong. Alternatively I could rename that block something like "Attempt options"...
          Hide
          Andrew Davis added a comment -

          Splitting the shifting of assignment.grade into a separate tracker issue. MDL-24049

          Show
          Andrew Davis added a comment - Splitting the shifting of assignment.grade into a separate tracker issue. MDL-24049

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: