Moodle
  1. Moodle
  2. MDL-19194

Sub folders in zip files are not being created

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.9.4
    • Fix Version/s: 1.9.5
    • Component/s: Files API
    • Labels:
      None
    • Environment:
      Windows 2003 IIS, MySQL 5, PHP 5
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      31697

      Description

      First noticed when SCORM packages did not work. Noticed root files of package unzipped but folders not created. Proceeded to uploaded a zip package to course Files and utilized Moodle to unzip package files in root extracted but not folders.

      1. unzip3.patch
        1 kB
        Petr Škoda

        Activity

        Hide
        Petr Škoda added a comment -

        could you please try to upload some sample zip file that does not work for you?

        Show
        Petr Škoda added a comment - could you please try to upload some sample zip file that does not work for you?
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Just tried USGOverview.zip under Mac OS X, both with internal and OS unzip from within Moodle. It contains:

        • engage.html
        • engage.swf
        • engage_content
          • various files
          • sounds
            • various files (mp3)

        So here it's unzipping ok. Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Just tried USGOverview.zip under Mac OS X, both with internal and OS unzip from within Moodle. It contains: engage.html engage.swf engage_content various files sounds various files (mp3) So here it's unzipping ok. Ciao
        Hide
        Chuck Griess added a comment -

        The file unzips and the sub folders are created in our Moodle 1.9.2+ (Build: 20080827) and on the same sever . The issue started when I updated to the MOODLE_STABLE branch CVS. I was updating 1.9.4 to 1.9.5. Hope this helps. Thanks again for the help.

        Show
        Chuck Griess added a comment - The file unzips and the sub folders are created in our Moodle 1.9.2+ (Build: 20080827) and on the same sever . The issue started when I updated to the MOODLE_STABLE branch CVS. I was updating 1.9.4 to 1.9.5. Hope this helps. Thanks again for the help.
        Hide
        Chuck Griess added a comment -

        I manually created the folders and put the proper files into the the appropriate directories and the SCORM packages work and the asset files to the articulate files work. This is what makes me believe it is related to the files api. thanks again

        Show
        Chuck Griess added a comment - I manually created the folders and put the proper files into the the appropriate directories and the SCORM packages work and the asset files to the articulate files work. This is what makes me believe it is related to the files api. thanks again
        Hide
        Petr Škoda added a comment -

        sending patch that should solve it, unfortunately it might create problems if networked \\dataroots\ are used on win32, need a lot more testing

        Show
        Petr Škoda added a comment - sending patch that should solve it, unfortunately it might create problems if networked \\dataroots\ are used on win32, need a lot more testing
        Hide
        Petr Škoda added a comment - - edited

        I found the problem, I need to test the patch a bit more, going to commit some solution tomorrow, thanks a lot for the report!

        Show
        Petr Škoda added a comment - - edited I found the problem, I need to test the patch a bit more, going to commit some solution tomorrow, thanks a lot for the report!
        Hide
        Chuck Griess added a comment -

        Cool thanks for the help I appreciate it thank you.

        Show
        Chuck Griess added a comment - Cool thanks for the help I appreciate it thank you.
        Hide
        Martin Dougiamas added a comment -

        Is this a recent regression? Do we need to rebuild 1.9.5 packages?

        Show
        Martin Dougiamas added a comment - Is this a recent regression? Do we need to rebuild 1.9.5 packages?
        Hide
        Petr Škoda added a comment -

        fixed, thanks

        Show
        Petr Škoda added a comment - fixed, thanks
        Hide
        Sam Hemelryk added a comment -

        Confirmed thanks, files unzipped correctly

        Show
        Sam Hemelryk added a comment - Confirmed thanks, files unzipped correctly

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: