Moodle
  1. Moodle
  2. MDL-19211

Text editors cleanup and improvements META

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: HTML Editor (TinyMCE)
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      1256

      Description

      • upgrade tinymce
      • make editors pluggable again
      • improve lang strings handling
      • upgrade DragMath
      • etc.

        Issue Links

        Progress
        Resolved Sub-Tasks

        Sub-Tasks

        There are no Sub-Tasks for this issue.

          Activity

          Hide
          Marc Grober added a comment -

          As the person nominally identified as the Moodle maintainer for DragMath, might I inquire as to:

          • how changing what is in Moodle HEAD to 0.7.7, which was out of date when the changes were made, constitutes "upgrading"
          • why DragMath has now been placed, contrary to the prior discussion, not in /lib/editor/common nor in /lib/common, but in /lib/dragmath
          • DragMath having been placed in /lib/dragmath, what is the intended abode of asciimathml and shouldn;t the locations demonstrate consistency, as per the MDLs that address dragmath and asciimath
          • Since you have been fiddling HEAD vis-a-vis DragMath, have you also now changed adminlib.php as previously suggested (forum postings seem to suggest that you did this but I don't see the line in adminlib.php)
          • who will close the half dozen MDL's regarding dragmath that this MDL has rendered moot.... it would seem that at least things should be linked and tagged as closed since those tracking the existing MDL's would have no clue that things took a hard right.....
          Show
          Marc Grober added a comment - As the person nominally identified as the Moodle maintainer for DragMath, might I inquire as to: how changing what is in Moodle HEAD to 0.7.7, which was out of date when the changes were made, constitutes "upgrading" why DragMath has now been placed, contrary to the prior discussion, not in /lib/editor/common nor in /lib/common, but in /lib/dragmath DragMath having been placed in /lib/dragmath, what is the intended abode of asciimathml and shouldn;t the locations demonstrate consistency, as per the MDLs that address dragmath and asciimath Since you have been fiddling HEAD vis-a-vis DragMath, have you also now changed adminlib.php as previously suggested (forum postings seem to suggest that you did this but I don't see the line in adminlib.php) who will close the half dozen MDL's regarding dragmath that this MDL has rendered moot.... it would seem that at least things should be linked and tagged as closed since those tracking the existing MDL's would have no clue that things took a hard right.....
          Hide
          Petr Škoda added a comment -

          1/ there can not be "common" in editor directory because we have editor plugins there, whoever invented it forgot how our plugins work
          2/ lib is the right place for imported libraries, it helps with maintenance
          3/ I did not want to be maintainer of editor integrations but unfortunately nobody was working on editor integrations
          4/ my current priority is to finalize editor embedding and only then start dealing with editor extensions, sorry if I broke anything
          5/ each imported library MUST have readme_moodle.txt which includes list of all changes, import steps but also the maintainer!
          6/ I do not understand what is your problem with 0.7.7, I took it from http://www.dragmath.bham.ac.uk/ which was at the time the latest version, the previous version was much older

          Show
          Petr Škoda added a comment - 1/ there can not be "common" in editor directory because we have editor plugins there, whoever invented it forgot how our plugins work 2/ lib is the right place for imported libraries, it helps with maintenance 3/ I did not want to be maintainer of editor integrations but unfortunately nobody was working on editor integrations 4/ my current priority is to finalize editor embedding and only then start dealing with editor extensions, sorry if I broke anything 5/ each imported library MUST have readme_moodle.txt which includes list of all changes, import steps but also the maintainer! 6/ I do not understand what is your problem with 0.7.7, I took it from http://www.dragmath.bham.ac.uk/ which was at the time the latest version, the previous version was much older
          Hide
          Marc Grober added a comment -

          In fact I initially argued for dragmath and asciimath to be located in /lib/common but was overruled by Matthieu... There were also some editor recommendations and demonstrations by Mauno (pretty exciting stuff) that were set aside at the time (gee, almost a year ago now??).... i.e. there were people working on editor integrations.....

          if dragmath is in lib/dragmath, then can we expect that asciimath will be in lib/asciimath?

          Dragmath 0.7.7 was broken (a new fix in the code to address implied multiplication apparently broke another function), Alex released 0.7.7.1 to resolve the issue and I created a fresh zip for moodlers. 0.7.8 was released to address java console errors MK was seeing as he developed SEE, his integration of dragmath, asciimath, and svg with tinyMCE. Have you reviewed his work?

          Show
          Marc Grober added a comment - In fact I initially argued for dragmath and asciimath to be located in /lib/common but was overruled by Matthieu... There were also some editor recommendations and demonstrations by Mauno (pretty exciting stuff) that were set aside at the time (gee, almost a year ago now??).... i.e. there were people working on editor integrations..... if dragmath is in lib/dragmath, then can we expect that asciimath will be in lib/asciimath? Dragmath 0.7.7 was broken (a new fix in the code to address implied multiplication apparently broke another function), Alex released 0.7.7.1 to resolve the issue and I created a fresh zip for moodlers. 0.7.8 was released to address java console errors MK was seeing as he developed SEE, his integration of dragmath, asciimath, and svg with tinyMCE. Have you reviewed his work?
          Hide
          Mauno Korpelainen added a comment -

          Hi Marc and Petr,

          you have written so many new tracker issues during my 2 holiday weeks that it is hard to follow all of them - anyway some comments in http://tracker.moodle.org/browse/MDL-19516 ...

          I'm not worried about different plugin structure of moodle 2.0 and previous versions - or different integration methods, different editors etc...

          Marc,

          I'm really pleased to see Petr taking care of editor code and plugins - I suppose he was not aware of your role and we have had so many different test integrations (trials) during the last few years (starting from Janne's work, my versions, Glen's version, OU version, Mathieu's moodle 2.0 version etc) that most likely nobody has tested all of them - not to mention math plugins etc.

          I am happy with any system that is stable and flexible enough for creating and using great features of moodle - both old and new ones... and I can change my files according to each version if needed...

          Show
          Mauno Korpelainen added a comment - Hi Marc and Petr, you have written so many new tracker issues during my 2 holiday weeks that it is hard to follow all of them - anyway some comments in http://tracker.moodle.org/browse/MDL-19516 ... I'm not worried about different plugin structure of moodle 2.0 and previous versions - or different integration methods, different editors etc... Marc, I'm really pleased to see Petr taking care of editor code and plugins - I suppose he was not aware of your role and we have had so many different test integrations (trials) during the last few years (starting from Janne's work, my versions, Glen's version, OU version, Mathieu's moodle 2.0 version etc) that most likely nobody has tested all of them - not to mention math plugins etc. I am happy with any system that is stable and flexible enough for creating and using great features of moodle - both old and new ones... and I can change my files according to each version if needed...
          Hide
          Andrew Davis added a comment -

          Looking to another editor issue that includes a patch we may want.

          Show
          Andrew Davis added a comment - Looking to another editor issue that includes a patch we may want.
          Hide
          Petr Škoda added a comment -

          All subtasks are resolved, please create new separate issues if necessary.

          Show
          Petr Škoda added a comment - All subtasks are resolved, please create new separate issues if necessary.

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: