Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-16345 Moodle 2.0 question bank improvements
  3. MDL-19213

Saving tags only on the question wizardpage that contain them normally first one as in calculated

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Questions
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      There is an error when using second and third page of calculated question editing as there is no tags on theses pages.
      So question.php line 208
      if (!empty($CFG->usetags))

      { require_once($CFG->dirroot.'/tag/lib.php'); tag_set('question', $question->id, $fromform->tags); }
      should be changed to

      if (!empty($CFG->usetags) && isset($fromform->tags)) { require_once($CFG->dirroot.'/tag/lib.php'); tag_set('question', $question->id, $fromform->tags); }

      I will CVs the correction in the next days (back to work tuesday).

        Attachments

          Activity

            People

            Assignee:
            ppichet Pierre Pichet
            Reporter:
            ppichet Pierre Pichet
            Participants:
            Component watchers:
            Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              24/Nov/10