Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19288

Context and modinfo caching regressions on large sites

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Blocker Blocker
    • 1.9.6
    • 1.9.5
    • Roles / Access
    • None
    • MOODLE_19_STABLE
    • MOODLE_19_STABLE

      the array_shift() call is not correct because it reorders the array - see MDL-18768

      From MDL-18768, by Colin Campbell:
      I am running into issues with this fix. The array_shift function renumbers numeric indexes. Consequently, as soon as we reach MAX_MODINFO_CACHE_SIZE in get_fast_modinfo, array_shift converts the cache keys from the course ids originally used to index the cache to sequential integers starting with zero. This causes all sorts of bad things to happen.

            skodak Petr Skoda (Inactive)
            skodak Petr Skoda (Inactive)
            Sam Hemelryk Sam Hemelryk
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.