Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19391

approve icon style need to be set to iconsmall in database module

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.2, 1.9.3, 1.9.4, 1.9.5, 1.9.10, 2.0.1, 2.1.4
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Database activity module
    • Labels:
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      As a teacher

      • Create a new database activity
        • Set the 'Require Approval' setting to 'Yes'
      • Create a field
      • Generate the default templates

      As a Student

      • Navigate to the database activity
      • Create a new record in the database

      As a teacher

      • Navigate to the database
      • Locate the newly created record awaiting approval
      • Confirm: The approval tick icon should be the same size as the other icons displayed
      Show
      As a teacher Create a new database activity Set the 'Require Approval' setting to 'Yes' Create a field Generate the default templates As a Student Navigate to the database activity Create a new record in the database As a teacher Navigate to the database Locate the newly created record awaiting approval Confirm: The approval tick icon should be the same size as the other icons displayed
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-19391-master-1
    • Pull Master Diff URL:

      Description

      We have a custom theme which is missing approve.gif icon used by database module, this was a bug reported in http://tracker.moodle.org/browse/MDL-8188. Upgrading process wouldn't add the icon automatically into your theme folder.

      I manually added this icon into theme folder, this icon was display in orignal size by default, it suppose set to "class=iconsmall", not "class=icon" in mod/data/lib.php line 955.

        Attachments

          Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32621 Database approve icon missing 'title' field

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-8188 MOODLE_17_STABLE missing file moodle/pix/i/approve.gif used by database module

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              nebgor Aparup Banerjee
              Reporter:
              lei.zhang Lei Zhang
              Peer reviewer:
              Sam Hemelryk
              Integrator:
              Sam Hemelryk
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/12