Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19391

approve icon style need to be set to iconsmall in database module

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.2, 1.9.3, 1.9.4, 1.9.5, 1.9.10, 2.0.1, 2.1.4
    • Fix Version/s: 2.1.6, 2.2.3
    • Labels:
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      As a teacher

      • Create a new database activity
        • Set the 'Require Approval' setting to 'Yes'
      • Create a field
      • Generate the default templates

      As a Student

      • Navigate to the database activity
      • Create a new record in the database

      As a teacher

      • Navigate to the database
      • Locate the newly created record awaiting approval
      • Confirm: The approval tick icon should be the same size as the other icons displayed
      Show
      As a teacher Create a new database activity Set the 'Require Approval' setting to 'Yes' Create a field Generate the default templates As a Student Navigate to the database activity Create a new record in the database As a teacher Navigate to the database Locate the newly created record awaiting approval Confirm: The approval tick icon should be the same size as the other icons displayed
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-19391-master-1

      Description

      We have a custom theme which is missing approve.gif icon used by database module, this was a bug reported in http://tracker.moodle.org/browse/MDL-8188. Upgrading process wouldn't add the icon automatically into your theme folder.

      I manually added this icon into theme folder, this icon was display in orignal size by default, it suppose set to "class=iconsmall", not "class=icon" in mod/data/lib.php line 955.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Raising to major, moved to STABLE backlog, randomly assigning to Aparup, could you:

            • check how this is looking, both under 1.9.x and 2.0.x
            • if there is anyything missing/displaying incorrectly, fix it.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Raising to major, moved to STABLE backlog, randomly assigning to Aparup, could you: check how this is looking, both under 1.9.x and 2.0.x if there is anyything missing/displaying incorrectly, fix it. TIA and ciao
            Hide
            nebgor Aparup Banerjee added a comment -

            up for peer review

            Show
            nebgor Aparup Banerjee added a comment - up for peer review
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Looks good to me thanks Apu, assumably you will forwardport this to 21 and master right.

            Show
            samhemelryk Sam Hemelryk added a comment - Looks good to me thanks Apu, assumably you will forwardport this to 21 and master right.
            Hide
            nebgor Aparup Banerjee added a comment -

            Thanks Sam. year will forward port (grr didn't get any email about your last comment)

            Show
            nebgor Aparup Banerjee added a comment - Thanks Sam. year will forward port (grr didn't get any email about your last comment)
            Hide
            dobedobedoh Andrew Nicols added a comment -

            I've just seen this issue on our deployment.

            I've verified that the supplied patch still cleanly cherry-picks without any need to rebase onto:

            • master
            • MOODLE_22_STABLE
            • MOODLE_21_STABLE
            Show
            dobedobedoh Andrew Nicols added a comment - I've just seen this issue on our deployment. I've verified that the supplied patch still cleanly cherry-picks without any need to rebase onto: master MOODLE_22_STABLE MOODLE_21_STABLE
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Provided some test instructions

            Show
            dobedobedoh Andrew Nicols added a comment - Provided some test instructions
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Forward-ported to master
            This commit cherry-picks cleanly to all stable branches

            Show
            dobedobedoh Andrew Nicols added a comment - Forward-ported to master This commit cherry-picks cleanly to all stable branches
            Hide
            dobedobedoh Andrew Nicols added a comment -

            No changes made except for porting to master so submitting for IR.

            Show
            dobedobedoh Andrew Nicols added a comment - No changes made except for porting to master so submitting for IR.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Andrew, this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now
            Hide
            abgreeve Adrian Greeve added a comment -

            This works fine on Master. I noticed that there is a branch for 2.0, so I tested that as well, but it doesn't look like it's been integrated into 20 (I don't see this as a problem as we have stopped support for 20)
            Thanks.

            Show
            abgreeve Adrian Greeve added a comment - This works fine on Master. I noticed that there is a branch for 2.0, so I tested that as well, but it doesn't look like it's been integrated into 20 (I don't see this as a problem as we have stopped support for 20) Thanks.
            Hide
            nebgor Aparup Banerjee added a comment -

            This had totally fell of my radar somehow, thanks guys!

            Show
            nebgor Aparup Banerjee added a comment - This had totally fell of my radar somehow, thanks guys!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            UPDATE tracker_issues
               SET status = 'Closed',
                  comment = 'Thanks!'
            WHEN participants = 'Did a gorgeous work'

            This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - UPDATE tracker_issues SET status = 'Closed', comment = 'Thanks!' WHEN participants = 'Did a gorgeous work' This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/12