Moodle
  1. Moodle
  2. MDL-19391

approve icon style need to be set to iconsmall in database module

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.2, 1.9.3, 1.9.4, 1.9.5, 1.9.10, 2.0.1, 2.1.4
    • Fix Version/s: 2.1.6, 2.2.3
    • Labels:
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      As a teacher

      • Create a new database activity
        • Set the 'Require Approval' setting to 'Yes'
      • Create a field
      • Generate the default templates

      As a Student

      • Navigate to the database activity
      • Create a new record in the database

      As a teacher

      • Navigate to the database
      • Locate the newly created record awaiting approval
      • Confirm: The approval tick icon should be the same size as the other icons displayed
      Show
      As a teacher Create a new database activity Set the 'Require Approval' setting to 'Yes' Create a field Generate the default templates As a Student Navigate to the database activity Create a new record in the database As a teacher Navigate to the database Locate the newly created record awaiting approval Confirm: The approval tick icon should be the same size as the other icons displayed
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-19391-master-1

      Description

      We have a custom theme which is missing approve.gif icon used by database module, this was a bug reported in http://tracker.moodle.org/browse/MDL-8188. Upgrading process wouldn't add the icon automatically into your theme folder.

      I manually added this icon into theme folder, this icon was display in orignal size by default, it suppose set to "class=iconsmall", not "class=icon" in mod/data/lib.php line 955.

        Gliffy Diagrams

          Issue Links

            Activity

            Lei Zhang created issue -
            Lei Zhang made changes -
            Field Original Value New Value
            Link This issue has a non-specific relationship to MDL-8188 [ MDL-8188 ]
            Martin Dougiamas made changes -
            Workflow jira [ 32221 ] MDL Workflow [ 44994 ]
            Eloy Lafuente (stronk7) made changes -
            Labels triaged
            Assignee moodle.com [ moodle.com ] Aparup Banerjee [ nebgor ]
            Fix Version/s STABLE backlog [ 10463 ]
            Affects Version/s 2.0.1 [ 10420 ]
            Affects Version/s 1.9.10 [ 10407 ]
            Priority Trivial [ 5 ] Major [ 3 ]
            Martin Dougiamas made changes -
            Workflow MDL Workflow [ 44994 ] MDL Full Workflow [ 73351 ]
            Aparup Banerjee made changes -
            Aparup Banerjee made changes -
            Status Open [ 1 ] Waiting for peer review [ 10012 ]
            Sam Hemelryk made changes -
            Original Estimate 0 minutes [ 0 ]
            Remaining Estimate 0 minutes [ 0 ]
            Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
            Peer reviewer samhemelryk
            Sam Hemelryk made changes -
            Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
            Andrew Nicols made changes -
            Testing Instructions h3. As a teacher
            * Create a new database activity
            ** Set the 'Require Approval' setting to 'Yes'
            * Create a field
            * Generate the default templates

            h3. As a Student
            * Navigate to the database activity
            * Create a new record in the database

            h3. As a teacher
            * Navigate to the database
            * Locate the newly created record awaiting approval
            * *Confirm:* The approval _tick_ icon should be the same size as the other icons displayed
            Andrew Nicols made changes -
            Affects Version/s 2.1.4 [ 11452 ]
            Andrew Nicols made changes -
            Andrew Nicols made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            Andrew Nicols made changes -
            Link This issue testing discovered MDL-32621 [ MDL-32621 ]
            Sam Hemelryk made changes -
            Currently in integration Yes [ 10041 ]
            Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator samhemelryk
            Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Fix Version/s 2.1.6 [ 12052 ]
            Fix Version/s 2.2.3 [ 12053 ]
            Fix Version/s STABLE backlog [ 10463 ]
            Michael de Raadt made changes -
            Tester abgreeve
            Adrian Greeve made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Adrian Greeve made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 04/May/12

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: