Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.5
    • Fix Version/s: 2.0
    • Component/s: General
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      35397

      Activity

      Hide
      Nicolas Connault added a comment -

      Attached a patch with ereg -> preg replacements. Please review

      Show
      Nicolas Connault added a comment - Attached a patch with ereg -> preg replacements. Please review
      Hide
      Nicolas Connault added a comment -

      The only ereg* functions left now are in third party libraries.

      Show
      Nicolas Connault added a comment - The only ereg* functions left now are in third party libraries.
      Hide
      Pierre Pichet added a comment -

      There is a problem in calculated/questiontype.php
      Warning: preg_match() [function.preg-match]: Unknown modifier '<' in C:\moodle\moodle\site\moodle_head\question\type\calculated\questiontype.php on line 1899

      This 1899 line explore the math formula.
      $safeoperatorchar = '-+/%>:^~<?=&|!'; / */
      $operatorornumber = "[$safeoperatorchar.0-9eE]";

      while (preg_match("(^|[$safeoperatorchar,(])([a-z0-9_]*)\\(($operatorornumber+(,$operatorornumber+((,$operatorornumber+)+)?)?)?
      )
      ",
      $formula, $regs)) {

      Show
      Pierre Pichet added a comment - There is a problem in calculated/questiontype.php Warning: preg_match() [function.preg-match] : Unknown modifier '<' in C:\moodle\moodle\site\moodle_head\question\type\calculated\questiontype.php on line 1899 This 1899 line explore the math formula. $safeoperatorchar = '-+/ %>:^~<?=&|!'; / */ $operatorornumber = " [$safeoperatorchar.0-9eE] "; while (preg_match(" (^| [$safeoperatorchar,(] )( [a-z0-9_] *)\\(($operatorornumber+(,$operatorornumber+((,$operatorornumber+)+)?)?)? ) ", $formula, $regs)) {
      Hide
      Jonathan Harker added a comment -

      Spotted a couple of stray ereg calls - committed.

      Show
      Jonathan Harker added a comment - Spotted a couple of stray ereg calls - committed.

        People

        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: