Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19543

overview page hardcodes max and min column widths

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.5, 2.0
    • Fix Version/s: 1.9.7
    • Component/s: Dashboard (My home)
    • Labels:
      None
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      Lines 60 and 116 of /my/index.php [1] hardcodes the min-max values for the column widths. It should be using $THEME->block_l/r_min/max_width settings. This is what other pages like index.php [2] do.

      [1] http://cvs.moodle.org/moodle/my/index.php?annotate=1.28#l60
      [2] http://cvs.moodle.org/moodle/index.php?annotate=1.233#l37

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            dougiamas Martin Dougiamas added a comment -

            Andrew, can you please try this out for 1.9 (and HEAD, though it's probably not necessary as that sort of code has changed) and post a full diff patch here to look at?

            Show
            dougiamas Martin Dougiamas added a comment - Andrew, can you please try this out for 1.9 (and HEAD, though it's probably not necessary as that sort of code has changed) and post a full diff patch here to look at?
            Hide
            andyjdavis Andrew Davis added a comment -

            1.9 patch attached. This issue doesn't appear to apply to 2.

            Show
            andyjdavis Andrew Davis added a comment - 1.9 patch attached. This issue doesn't appear to apply to 2.
            Hide
            dongsheng Dongsheng Cai added a comment -

            Thanks for fixing this, looks good, closing.

            Show
            dongsheng Dongsheng Cai added a comment - Thanks for fixing this, looks good, closing.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Nov/09