Moodle
  1. Moodle
  2. MDL-19549

The english update timezones message tries to reasure but puts doubts in my mind

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.9.5, 2.2
    • Fix Version/s: 2.2.3
    • Component/s: Language
    • Labels:
    • Rank:
      7057

      Description

      $string['configintrotimezones'] = 'This page will search for new information about world timezones (including daylight savings time rules) and update your local database with this information. These locations will be checked, in order: $a This procedure is generally very safe and can not break normal installations. Do you wish to update your timezones now?';

      I think it would reassure me more if all operations were safe and don't need a message telling users it wont break their installation! Could we change to:

      $string['configintrotimezones'] = 'This page will search for new information about world timezones (including daylight savings time rules) and update your local database with this information. These locations will be checked, in order: $a Do you wish to update your timezones now?';

      Votes, please!

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this issue.

        We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

        If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

        Michael d;

        lqjjLKA0p6

        Show
        Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
        Hide
        Dan Poltawski added a comment -

        Still in the lang file in 2.2

        Show
        Dan Poltawski added a comment - Still in the lang file in 2.2
        Hide
        Dan Poltawski added a comment -

        Hi Helen,

        What do you think about my suggested lanaguage change? (from ages ago!)

        Show
        Dan Poltawski added a comment - Hi Helen, What do you think about my suggested lanaguage change? (from ages ago!)
        Hide
        Helen Foster added a comment -

        Hi Dan,

        Removing 'This procedure is generally very safe and can not break normal installations.' has my vote! Sorry for taking so long to reply.

        Show
        Helen Foster added a comment - Hi Dan, Removing 'This procedure is generally very safe and can not break normal installations.' has my vote! Sorry for taking so long to reply.
        Hide
        Dan Poltawski added a comment -

        I've fixed this for 2.2 and master. Since things have been moved around and this string has been around for ages I didn't bother with 2.1

        Show
        Dan Poltawski added a comment - I've fixed this for 2.2 and master. Since things have been moved around and this string has been around for ages I didn't bother with 2.1
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (22 & master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (22 & master), thanks!
        Hide
        Jason Fowler added a comment -

        looks good

        Show
        Jason Fowler added a comment - looks good
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This has been near becoming rejected, because it's not the best code you are able to produce.

        But, luckily, at the end, it has landed and has been spread to all repos out there.

        Many thanks and, don't forget it, keep improving your skills, you can!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: