While looking into MDL-19554, I've noticed that format_text() returns
immediately if $text is '', but goes through full filtering/caching if
$text is NULL. Perhaps it can take the same shortcut? TIA.
Assigning to David, sending to stable backlog and raising to critical hoping to get this fixed in next performance-focussed sprint.
Note this needs fix both for 1.9.x and 2.0.x
Thanks for the report!
Thanks Matej for the patch.
However, in this function, $text must always be set and its only checking for null value, therefore, I'm changing isset() to is_null().
I will ask Sam to comment regarding this.
diff patch (1.9): https://github.com/rwijaya/moodle/compare/MOODLE_19_STABLE...MDL-19555_m19
diff patch (2.0): https://github.com/rwijaya/moodle/compare/master...MDL-19555_m20
Looks good thanks Rosie gets my +1
Thanks Sam for reviewing.
Submitted to pull request:
Reopening so that a 2.0.3 fix version can be set. Also, let's wait until the weekly package is available before closing. Apologies for the extra notification emails.