Moodle
  1. Moodle
  2. MDL-19560

Regression: A forcedownload error caused SCORM mod not works.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Cannot Reproduce
    • Affects Version/s: 1.9.5
    • Fix Version/s: 1.9.6
    • Component/s: SCORM
    • Labels:
      None
    • Environment:
      Linux, MySQL, Moodle 1.9.5
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      31637

      Description

      Some moodle security codes in file.php:

      if (!$forcedownload) {
      require_once("$CFG->dirroot/mod/$mod/lib.php");
      $trustedfunction = $mod.'_is_moddata_trusted';
      if (function_exists($trustedfunction))

      { // force download of all attachments that are not trusted $forcedownload = !$trustedfunction(); }

      else

      { $forcedownload = 1; }

      }

      Caused SCORM module always force user to download the scorm content instead of display it.

      After check mod/scorm/lib.php, there was no "scorm_is_moddata_trusted" function. After add such function and make it always return true(trusted scorm data because it only can be uploaded by tutor/admin), it works.

        Activity

        Tang Wei created issue -
        Dan Marsden made changes -
        Field Original Value New Value
        Assignee Dan Marsden [ danmarsden ] Petr Skoda [ skodak ]
        Dan Marsden made changes -
        Summary A forcedownload error caused SCORM mod not works. Regression: A forcedownload error caused SCORM mod not works.
        Priority Minor [ 4 ] Blocker [ 1 ]
        Dan Marsden made changes -
        Fix Version/s 1.9.6 [ 10340 ]
        Petr Škoda made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Petr Škoda made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Cannot Reproduce [ 5 ]
        Dan Marsden made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        QA Assignee danmarsden
        Martin Dougiamas made changes -
        Workflow jira [ 32422 ] MDL Workflow [ 62675 ]
        Martin Dougiamas made changes -
        Workflow MDL Workflow [ 62675 ] MDL Full Workflow [ 91892 ]

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: