Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19598

Access: Should not print skip link for block with no title

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.5
    • Fix Version/s: 1.9.6
    • Component/s: Accessibility
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      When blocks have no title, there is code that is supposed to stop it printing out the skip link (as it does not make sense to have a skip link that offers to 'Skip [blank]' - how is the user supposed to know what they are skipping).

      Unfortunately this code is broken. I am going to fix it.

        Gliffy Diagrams

          Activity

          Hide
          quen Sam Marshall added a comment -

          Fixed in 1.9 and HEAD.

          Basically the logic was broken because it was testing if(!empty($heading)), but $heading is something like <h2></h2> when it's empty, so this wasn't right - should have used $title instead. It was already using $title for the actual text within the skip link.

          Show
          quen Sam Marshall added a comment - Fixed in 1.9 and HEAD. Basically the logic was broken because it was testing if(!empty($heading)), but $heading is something like <h2></h2> when it's empty, so this wasn't right - should have used $title instead. It was already using $title for the actual text within the skip link.
          Hide
          tsala Helen Foster added a comment -

          Sam, thanks for reporting and fixing this issue.

          Tested in 1.9.5+ by creating an html block with no title then examining the source code.

          (Amending the fix version to 1.9.6 only, as HEAD should not be included unless it's the only version.)

          Show
          tsala Helen Foster added a comment - Sam, thanks for reporting and fixing this issue. Tested in 1.9.5+ by creating an html block with no title then examining the source code. (Amending the fix version to 1.9.6 only, as HEAD should not be included unless it's the only version.)

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                21/Oct/09