Moodle
  1. Moodle
  2. MDL-19742

Calendar language strings casing inconsistent

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.9.5, 2.0
    • Fix Version/s: 2.0
    • Component/s: Calendar, Language
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      35237

      Description

      I was doing a demo with a client and they mentioned that the casing for some of the language strings was inconsistent. The standard in Moodle is that we use initial first cap and the rest of the string is lower case; however, a couple of strings that stood out were:

      $string['dayview'] = 'Day View';
      $string['detailedmonthview'] = 'Detailed Month View';
      $string['eventview'] = 'Event Details';
      $string['monthlyview'] = 'Monthly View';
      $string['newevent'] = 'New Event';
      $string['upcomingevents'] = 'Upcoming Events';

      Any objection to changing these to Day view, Detailed month view, Event details, Monthly view, New event, and Upcoming events?

      Thanks - Anthony

        Issue Links

          Activity

          Hide
          Anthony Borrow added a comment -

          assigning to Koen

          Show
          Anthony Borrow added a comment - assigning to Koen
          Hide
          Anthony Borrow added a comment -

          Koen - If it helps, here is a patch file of the inconsistencies that I found. Peace - Anthony

          Show
          Anthony Borrow added a comment - Koen - If it helps, here is a patch file of the inconsistencies that I found. Peace - Anthony
          Hide
          Koen Roggemans added a comment -

          More English language pack improving stuff

          Show
          Koen Roggemans added a comment - More English language pack improving stuff
          Hide
          Helen Foster added a comment -

          Anthony, thanks for your report.

          Can you point out for me where it is stated that the standard in Moodle is to use initial first capital and the rest of the string is lower case. It's just that I notice most blocks seem to be named with both words being capitalized e.g. 'Recent Activity'.

          Show
          Helen Foster added a comment - Anthony, thanks for your report. Can you point out for me where it is stated that the standard in Moodle is to use initial first capital and the rest of the string is lower case. It's just that I notice most blocks seem to be named with both words being capitalized e.g. 'Recent Activity'.
          Hide
          Anthony Borrow added a comment -

          Helen - I have checked the obvious places and did not find it. A long time ago I believe it was Martin who had suggested to me that the default in Moodle was to do an initial capital and the rest lower case. If I come across the details of that transaction I will let you know. Peace - Anthony

          Show
          Anthony Borrow added a comment - Helen - I have checked the obvious places and did not find it. A long time ago I believe it was Martin who had suggested to me that the default in Moodle was to do an initial capital and the rest lower case. If I come across the details of that transaction I will let you know. Peace - Anthony
          Hide
          Helen Foster added a comment -

          Casing changed as suggested.

          Show
          Helen Foster added a comment - Casing changed as suggested.

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: