Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19764

Editing the country list in a language does not change the list in-site

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.5
    • Fix Version/s: 1.9.6
    • Component/s: Language
    • Labels:
      None
    • Environment:
      N/A - Tested on Server 2003 Apache and Wamp Apache
    • Database:
      Any
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      When doing the following

      • Log in as admin
      • Go to administration
      • Language
      • Language editing
      • Edit words or phrases
      • Countries.php
      • Find Taiwan, Prov...
      • Remove the ', Prov...' bit
      • Press 'Save countries.php'

      Here the differences start. On the live server it says

      Changes saved (C:\data\languagehouse\moodledata/lang/en_utf8_local/countries.php)

      However it also says

      No missing strings

      On the test server it says

      Changes saved (C:\wamp\moodledata/lang/en_utf8_local/countries.php)

      However it also says

      Number of missing strings: 1

      Taiwan is highlighted green as a missing string and DOES have the new edited text.

      The trouble is that this still doesn't change the country list in edit profile.

      [What needs to change]

      In moodlelib.php around line 5739

      if (!file_exists($CFG->dirroot .'/lang/'. $lang .'/countries.php') &&
      !file_exists($CFG->dataroot.'/lang/'. $lang .'/countries.php')) {

      Must change to

      if (!file_exists($CFG->dirroot .'/lang/'. $lang .'/countries.php') &&
      !file_exists($CFG->dataroot.'/lang/'. $lang . '_local' . '/countries.php')) {

      OR

      When creating the folder in moodledata\lang the file should be called en_utf8 instead of en_utf8_local

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            mediaguy Graham Robinson
            Participants:
            Component watchers:
            cameron1729, David Mudrák (@mudrd8mz), Helen Foster
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              21/Oct/09