Moodle
  1. Moodle
  2. MDL-19774

cron should not use globals $PAGE or $USER. function cron_setup_user should go

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Won't Fix
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Administration
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      1242

      Description

      I think that any code that may be used in a cron script should not rely on the globals $PAGE, $USER, etc.

      Instead, it should take an explicit $page, $user arguments to any functions. Then we could delete the cron_setup_user function completely.

      If that is not possible, perhaps for backwards compatibility, then we should not try to modify the global $PAGE. Instead we should create a new one when necessary.

        Activity

        Hide
        Jay Knight added a comment -

        I don't know it if this is really related to this bug, but a fix to this bug would make this go away too, I think:

        In lib/sessionlib.php on line 971, $cronsession is created as an array instead of an object which eventually gets assigned to $SESSION. This messes stuff up later when it $SESSION is used as an object.

        Show
        Jay Knight added a comment - I don't know it if this is really related to this bug, but a fix to this bug would make this go away too, I think: In lib/sessionlib.php on line 971, $cronsession is created as an array instead of an object which eventually gets assigned to $SESSION. This messes stuff up later when it $SESSION is used as an object.
        Hide
        Petr Škoda added a comment -

        Thank you for the report, I have committed your fix into CVS.

        Petr Skoda

        Show
        Petr Škoda added a comment - Thank you for the report, I have committed your fix into CVS. Petr Skoda
        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this issue.

        We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

        If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

        Michael d.

        TW9vZGxlDQo=

        Show
        Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
        Hide
        Michael de Raadt added a comment -

        I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

        This is being done as part of a bulk annual clean-up of issues.

        If you still believe this is an issue in supported versions, please create a new issue.

        Show
        Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: