Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: None
    • Component/s: General
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_15_STABLE

      Description

      Don't know what happened to the source, but there are (trivial) parse errors in what I just checked out from CVS:

      lib/datalib.php:

      • line 203 '. $field .' TO '. $realfield'); // ' too much
      • line 1486: $search='', $firstinitial='', $lastinitial=') { // instead of '

      lib/moodlelib.php

      • line 2141 $langfile = $langpath .'/'. $lang .'/'. $module .'.php'.; // trailing dot too much

      After fixing these, I get redirected from /moodle/ to /moodle/$url (really!), I'm just trying to find why that is.

        Gliffy Diagrams

          Activity

          Hide
          dougiamas Martin Dougiamas added a comment -

          From Daryl Hawes (dhawes at mac.com) Thursday, 23 September 2004, 10:53 AM:

          I ran through the 3 major libraries and converted double quote strings to single quote literals. Thanks for catching these issues with these changes. The lines you found in datalib and moodleib have been modified and uploaded to cvs. Since this was such a large change to the core files please keep an eye out for any more of these little errors that slipped in.

          From Sam O (ottenhoff at longsight.com) Saturday, 25 September 2004, 06:08 AM:

          I added patch.txt to fix several trivial issues (mainly quotes) I found with PHPEclipse.

          From Daryl Hawes (dhawes at mac.com) Saturday, 25 September 2004, 07:21 AM:

          ottenhoff, I have modified all of the files that you referenced and uploaded the changes to cvs. Please verify the changes when you get a moment. I'll also add a note that these changes were not related to this bug as they were found in files that were not modified for quote conversion. Only datalib, moodlib and weblib were modified. Thanks, Daryl.

          Show
          dougiamas Martin Dougiamas added a comment - From Daryl Hawes (dhawes at mac.com) Thursday, 23 September 2004, 10:53 AM: I ran through the 3 major libraries and converted double quote strings to single quote literals. Thanks for catching these issues with these changes. The lines you found in datalib and moodleib have been modified and uploaded to cvs. Since this was such a large change to the core files please keep an eye out for any more of these little errors that slipped in. From Sam O (ottenhoff at longsight.com) Saturday, 25 September 2004, 06:08 AM: I added patch.txt to fix several trivial issues (mainly quotes) I found with PHPEclipse. From Daryl Hawes (dhawes at mac.com) Saturday, 25 September 2004, 07:21 AM: ottenhoff, I have modified all of the files that you referenced and uploaded the changes to cvs. Please verify the changes when you get a moment. I'll also add a note that these changes were not related to this bug as they were found in files that were not modified for quote conversion. Only datalib, moodlib and weblib were modified. Thanks, Daryl.
          Hide
          mblake Michael Blake added a comment -

          Temp reopen to assign to a valid user. Daryl Hawes.

          Show
          mblake Michael Blake added a comment - Temp reopen to assign to a valid user. Daryl Hawes.
          Hide
          mblake Michael Blake added a comment -

          Reassigning to a valid user.

          Show
          mblake Michael Blake added a comment - Reassigning to a valid user.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: