Moodle

A new comments block, so people can add commenting anywhere

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Commenting
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

We could create a new block that just shows the commenting UI. This would let teachers and commenting on any page, if it does not already have it.

Issue Links

has a non-specific relationship to

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-30375 Comments block disappears when cancel is clicked

  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
will be (partly) resolved by

New Feature - A new Moodle feature which has yet to be developed. MDL-19118 Comments 2.0

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin Dougiamas added a comment -

+100

It would be like a Shoutbox.

Show
Martin Dougiamas added a comment - +100 It would be like a Shoutbox.
Hide
Permalink
Dongsheng Cai added a comment -

The first patch.

currently don't have any callback function for this block, I hope we can have a lib.php for each block, I created a function "plugin_callback" in lib/moodlelib.php.

Show
Dongsheng Cai added a comment - The first patch. currently don't have any callback function for this block, I hope we can have a lib.php for each block, I created a function "plugin_callback" in lib/moodlelib.php.
Hide
Permalink
Dongsheng Cai added a comment -

because moodle form cannot return the form html, the block doesn't work well in non-js UI, I think we need to drop the comments moodle form in block

Show
Dongsheng Cai added a comment - because moodle form cannot return the form html, the block doesn't work well in non-js UI, I think we need to drop the comments moodle form in block
Hide
Permalink
Dongsheng Cai added a comment -

Please review, thanks

Show
Dongsheng Cai added a comment - Please review, thanks
Hide
Permalink
Martin Dougiamas added a comment -

Just reviewed: here are some things that should be fixed.

1) Make the icon half-size (the same as the Online Users block).
2) Reduce the whitepace between icon and text, to let the text have more room.
3) Use a more abbreviated date string when in the block. Suggest: get_string('strftimerecent', 'langconfig')
4) Hitting "cancel" will kill the block contents completely.

Show
Martin Dougiamas added a comment - Just reviewed: here are some things that should be fixed. 1) Make the icon half-size (the same as the Online Users block). 2) Reduce the whitepace between icon and text, to let the text have more room. 3) Use a more abbreviated date string when in the block. Suggest: get_string('strftimerecent', 'langconfig') 4) Hitting "cancel" will kill the block contents completely.
Hide
Permalink
Dongsheng Cai added a comment -

added, feel free to reopen it for fixing

Show
Dongsheng Cai added a comment - added, feel free to reopen it for fixing

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: