[MDL-19888] Deprecate addslashes_js - Moodle Tracker

XML

Word

Printable

Type: Task
Status: Closed
Priority: Minor
Resolution: Won't Do
Affects Version/s: 2.0, 2.6.1, 2.7.1
Fix Version/s: None
Component/s: Chat, Choice, Gradebook, JavaScript, Libraries, Resource, SCORM
Labels:
- triaged

All our new code like $PAGE->requires->data_for_js and ->js_function_call automatically does json_encode on data, which is better than addslashes_js.

A quiz grep finds about 50 references in HEAD. We need to

1. Eliminate all calls in core.
2. Move it to deprecatedlib.php and add debugging output.

will be (partly) resolved by

MDL-46505 improve structure of scorm/datamodel/debug.js.php

MDL-46507 remove addslashes_js from delete attempt forms in SCORM reports

Participants:: Andrew Lyons, Dan Marsden, Dan Poltawski, Matt Porritt, Michael de Raadt, Moodle HQ, Petr Skoda, Tim Hunt

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona), Dan Marsden, Amaia Anabitarte, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona), Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Dan Marsden, Matteo Scaramuccia, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie