Moodle
  1. Moodle
  2. MDL-19986

Course highlight section - Light Globe not showing

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.5
    • Fix Version/s: 2.3
    • Component/s: AJAX and JavaScript
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE

      Description

      When a topic is highlighted the light globe symbol on the right side does not toggle.
      See Forum post http://moodle.org/mod/forum/discuss.php?d=126393.

      Here is the fix:
      You have to replace the image \pix\i\marked.gif because marker.gif and marked.gif are the same images.

      RCS file: /cvsroot/moodle/moodle/lib/ajax/section_classes.js,v
      retrieving revision 1.35.2.8
      diff -u -r1.35.2.8 section_classes.js
      — section_classes.js 7 May 2009 09:44:07 -0000 1.35.2.8
      +++ section_classes.js 11 Aug 2009 08:49:40 -0000
      @@ -75,6 +75,10 @@
      if (YAHOO.util.Dom.hasClass(this.getEl(),'hidden'))

      { this.toggle_hide(null,null,true); }

      + //MWo 090701
      + if (YAHOO.util.Dom.hasClass(this.getEl(),'current'))

      { + this.set_highlight(); + }

      }

      @@ -323,12 +327,26 @@
      }

      +//MWo 090701 section_class.prototype.set_highlight
      +section_class.prototype.set_highlight = function() {
      + if (!this.highlighted)

      { + this.highlightButton.childNodes[0].src = this.highlightButton.childNodes[0].src.replace('marked.gif', 'marker.gif'); + this.highlighted = false; + }

      else

      { + this.highlightButton.childNodes[0].src = this.highlightButton.childNodes[0].src.replace('marker.gif', 'marked.gif'); + this.highlighted = true; + }

      +}
      +
      +
      section_class.prototype.toggle_highlight = function() {
      if (this.highlighted)

      { YAHOO.util.Dom.removeClass(this.getEl(), 'current'); + this.highlightButton.childNodes[0].src = this.highlightButton.childNodes[0].src.replace('marked.gif', 'marker.gif');//MWo 090701 this.highlighted = false; }

      else

      { YAHOO.util.Dom.addClass(this.getEl(), 'current'); + this.highlightButton.childNodes[0].src = this.highlightButton.childNodes[0].src.replace('marker.gif', 'marked.gif');//MWo 090701 this.highlighted = true; }

      }

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Mathias Wortmann added a comment -

            Changed Text to Diff Output

            Show
            Mathias Wortmann added a comment - Changed Text to Diff Output
            Hide
            Séverin Terrier added a comment -

            This error is still here in Moodle 2.1.1

            Show
            Séverin Terrier added a comment - This error is still here in Moodle 2.1.1
            Hide
            Ruslan Kabalin added a comment -

            Just to avoid confusion, please note that the marker.gif and marked.gif icons are actually different (in 2.2 and 2.1 at least), one of them is white and another one is transparent, that is why on the white background they might look identical.

            Show
            Ruslan Kabalin added a comment - Just to avoid confusion, please note that the marker.gif and marked.gif icons are actually different (in 2.2 and 2.1 at least), one of them is white and another one is transparent, that is why on the white background they might look identical.
            Hide
            Dan Poltawski added a comment -

            This has been fixed by MDL-31052 in 2.3

            Show
            Dan Poltawski added a comment - This has been fixed by MDL-31052 in 2.3

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: