Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19986

Course highlight section - Light Globe not showing

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.5
    • Fix Version/s: 2.3
    • Component/s: JavaScript
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE

      Description

      When a topic is highlighted the light globe symbol on the right side does not toggle.
      See Forum post http://moodle.org/mod/forum/discuss.php?d=126393.

      Here is the fix:
      You have to replace the image \pix\i\marked.gif because marker.gif and marked.gif are the same images.

      RCS file: /cvsroot/moodle/moodle/lib/ajax/section_classes.js,v
      retrieving revision 1.35.2.8
      diff -u -r1.35.2.8 section_classes.js
      — section_classes.js 7 May 2009 09:44:07 -0000 1.35.2.8
      +++ section_classes.js 11 Aug 2009 08:49:40 -0000
      @@ -75,6 +75,10 @@
      if (YAHOO.util.Dom.hasClass(this.getEl(),'hidden'))

      { this.toggle_hide(null,null,true); }

      + //MWo 090701
      + if (YAHOO.util.Dom.hasClass(this.getEl(),'current'))

      { + this.set_highlight(); + }

      }

      @@ -323,12 +327,26 @@
      }

      +//MWo 090701 section_class.prototype.set_highlight
      +section_class.prototype.set_highlight = function() {
      + if (!this.highlighted)

      { + this.highlightButton.childNodes[0].src = this.highlightButton.childNodes[0].src.replace('marked.gif', 'marker.gif'); + this.highlighted = false; + }

      else

      { + this.highlightButton.childNodes[0].src = this.highlightButton.childNodes[0].src.replace('marker.gif', 'marked.gif'); + this.highlighted = true; + }

      +}
      +
      +
      section_class.prototype.toggle_highlight = function() {
      if (this.highlighted)

      { YAHOO.util.Dom.removeClass(this.getEl(), 'current'); + this.highlightButton.childNodes[0].src = this.highlightButton.childNodes[0].src.replace('marked.gif', 'marker.gif');//MWo 090701 this.highlighted = false; }

      else

      { YAHOO.util.Dom.addClass(this.getEl(), 'current'); + this.highlightButton.childNodes[0].src = this.highlightButton.childNodes[0].src.replace('marker.gif', 'marked.gif');//MWo 090701 this.highlighted = true; }

      }

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  2 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12