Bullet points in topic summary cause AJAX to fail

This is due to the page being built using <ul> and <li>'s.

The ajax loads over the page searching for <ul> objects and applying the ajax features (buttons) to resources per topic block.

The problem is the summary box loads before the actual content div for the topic so when the ajax script comes across the <ul> in the summary box it assumes it has to apply the ajax features to that <ul> but it shouldn't.

I've modified the following page and it seems to have fixed the issue (and should work even if someone puts lots of <ul>'s in the summary box)

–
lib/ajax/section_classes.js
141: change: this.resources_ul = this.content_td.getElementsByTagName('ul')[0];
to: this.resources_ul = this.content_td.getElementsByTagName('ul')[0]; var i=0; while (this.resources_ul.className != 'section img-text')

–

It's based on matching the classname of the ul that shapes the page content, I can't assume it will work for every theme but I shouldn't see why a theme would have altered the CSS class for the sections in course/view.php.

Greg.

Alteration:

If a topic block is empty of content this cause the code to fail - here is the updated version:

this.resources_ul = this.content_td.getElementsByTagName('ul')[0]; var i=0; while (this.resources_ul && this.resources_ul.className != 'section img-text')

Hi Rossi, wanna have a look at this

Greg suggetion fix the issue on my 1.9stable version.

Thanks Greg from writting the solution for this issue.

creating patch for the issue.

committed to 1.9stable

Hi Rossi, does this need to be merged to HEAD?

re-open to fix in 2.0

Attached patch to fix 2.0

Commit patch to 2.0