Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20057

Restore Silently Isn't Silent

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.3
    • Fix Version/s: 1.9.5
    • Component/s: Backup
    • Labels:
      None
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      Currently, restore_execute() [backup/restorelib.php] is not completely silent when RESTORE_SILENTLY.

      For Moodle 1.9.3 (as reference because xref still points at 1.9.3):

      7523 if ($status = restore_open_html($restore,$course_header))

      { 7524 echo "<li>Creating the Restorelog.html in the course backup folder</li>"; 7525 }

      Surrounding all other echoes in restore_execute() is this check:

      if (!defined('RESTORE_SILENTLY')) {

      Shouldn't the restorelog echo also be wrapped in a conditional that checks RESTORE_SILENTLY?

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              danmarsden Dan Marsden
              Reporter:
              ebollens Eric Bollens
              Tester:
              Rossiani Wijaya
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/May/09