Moodle
  1. Moodle
  2. MDL-20124

Add GSOC PaintWeb integration with TinyMCE code to Moodle 2.0

    Details

    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      1263

      Description

      The work on the 2009 GSOC project to integrate PaintWeb wtih TinyMCE as progressed nicely and should be considered for inclusion with Moodle 2.0 where it will provide a new set of whistles and bells for the improvements to the HTML editor. Information about the paintweb project can be found at:

      http://docs.moodle.org/en/GSOC/2009#What_you_paint_is_what_you_get

      The plan is to have the code added to CORE for Moodle 2.0 and to provide a patch in CONTRIB for Moodle 1.9 (see CONTRIB-1456). Hopefully, we can get a test site created on test.moodle.org (see MDLSITE-788).

      Peace - Anthony

        Issue Links

          Activity

          Hide
          Anthony Borrow added a comment -

          linking the various PaintWeb related issues

          Show
          Anthony Borrow added a comment - linking the various PaintWeb related issues
          Hide
          Anthony Borrow added a comment -

          fyi - the code can be found at http://repo.or.cz/w/moodle/mihaisucan.git

          Show
          Anthony Borrow added a comment - fyi - the code can be found at http://repo.or.cz/w/moodle/mihaisucan.git
          Hide
          Helen Foster added a comment -

          For anyone wishing to try Paintweb in Moodle 2.0, please visit the test site http://test.moodle.org/paintweb/

          Show
          Helen Foster added a comment - For anyone wishing to try Paintweb in Moodle 2.0, please visit the test site http://test.moodle.org/paintweb/
          Hide
          Olli Savolainen added a comment -

          Hi,
          Sorry for my bug report in this format and not as separate tickets. Was testing the paint tool out at test.moodle.org and thought you would appreciate this better than nothing.

          "Confirmed: the rich text editor does not show on Google Chrome on Linux when creating new post, but appears when the post is edited.

          Oh, the icon for PaintWeb is great now, and overlapping the tinymce toolbar border makes it more noticeable. Great!

          Sorry for ruining your fun by being boring and spotting bugs, just thought it would be helpful if I wrote them down at least somewhere

          • Olli Savolainen"
          Show
          Olli Savolainen added a comment - Hi, Sorry for my bug report in this format and not as separate tickets. Was testing the paint tool out at test.moodle.org and thought you would appreciate this better than nothing. "Confirmed: the rich text editor does not show on Google Chrome on Linux when creating new post, but appears when the post is edited. Oh, the icon for PaintWeb is great now, and overlapping the tinymce toolbar border makes it more noticeable. Great! Sorry for ruining your fun by being boring and spotting bugs, just thought it would be helpful if I wrote them down at least somewhere Olli Savolainen"
          Hide
          Mihai Sucan added a comment -

          Hey Olli!

          Thanks for your bug report.

          1. The rich text editor does not show on Google Chrome on Linux when creating a new post, but it appears when the post is edited - I think i noticed this some times. That's a bug more related to the TinyMCE integration into Moodle 2, which was heavily worked on. And Petr plans to do more work on it.

          2. Yep, icon is now fixed.

          3. The bug that shadows do not render in Google Chrome is known. The problem does not affect Safari, even if it uses the same rendering engine. Here's the upstream bug report:

          http://code.google.com/p/chromium/issues/detail?id=11153

          (maybe you can place a vote for the bug, by starring the issue, hehe)

          4. Regarding the undo issue, please try to reproduce the bug and provide the exact steps. This is too vague and I don't know what could have went wrong.

          5. Regarding the border width and the font size errors .... please tell me more details. Are you using Google Chrome on Linux? Which version and build? It should be noted Google Chrome is quite ... alpha/unstable. At times the ellipse tool failed to work in Chrome on Linux, then it got fixed, and etc. The browser is not a very good measure for PaintWeb due to their bugs.

          Please retest in a different browser and let me know if those work or not - reproducible steps are best. These work for me.

          6. The fill tool? You can have text drawn with a fill, see the Border tab, shape type: filled, strokes only, or both. The bucket tool is missing at the moment and it's planned.

          7. Text cannot be split across multiple lines, at least not now.

          8. By pressing Escape while the Text tool is active you go back to the previous drawing tool. Suggestions for a better user interaction are welcome.

          If you want, you can use the PaintWeb issue tracker at Google Code, so we do not clutter this place. If you decide to do so, please post only one issue report for each problem you encounter. If that is too much trouble, then please reply here.

          Thank you very much again!

          Show
          Mihai Sucan added a comment - Hey Olli! Thanks for your bug report. 1. The rich text editor does not show on Google Chrome on Linux when creating a new post, but it appears when the post is edited - I think i noticed this some times. That's a bug more related to the TinyMCE integration into Moodle 2, which was heavily worked on. And Petr plans to do more work on it. 2. Yep, icon is now fixed. 3. The bug that shadows do not render in Google Chrome is known. The problem does not affect Safari, even if it uses the same rendering engine. Here's the upstream bug report: http://code.google.com/p/chromium/issues/detail?id=11153 (maybe you can place a vote for the bug, by starring the issue, hehe) 4. Regarding the undo issue, please try to reproduce the bug and provide the exact steps. This is too vague and I don't know what could have went wrong. 5. Regarding the border width and the font size errors .... please tell me more details. Are you using Google Chrome on Linux? Which version and build? It should be noted Google Chrome is quite ... alpha/unstable. At times the ellipse tool failed to work in Chrome on Linux, then it got fixed, and etc. The browser is not a very good measure for PaintWeb due to their bugs. Please retest in a different browser and let me know if those work or not - reproducible steps are best. These work for me. 6. The fill tool? You can have text drawn with a fill, see the Border tab, shape type: filled, strokes only, or both. The bucket tool is missing at the moment and it's planned. 7. Text cannot be split across multiple lines, at least not now. 8. By pressing Escape while the Text tool is active you go back to the previous drawing tool. Suggestions for a better user interaction are welcome. If you want, you can use the PaintWeb issue tracker at Google Code, so we do not clutter this place. If you decide to do so, please post only one issue report for each problem you encounter. If that is too much trouble, then please reply here. Thank you very much again!
          Hide
          Helen Foster added a comment -

          Mihai, please don't worry about cluttering the tracker! Much better to report issues in the tracker so that the Moodle community can easily watch, vote and comment on them.

          Show
          Helen Foster added a comment - Mihai, please don't worry about cluttering the tracker! Much better to report issues in the tracker so that the Moodle community can easily watch, vote and comment on them.
          Hide
          Mihai Sucan added a comment -

          Thanks Helen! Great! Then maybe Olli could report the issues he finds in this tracker for PaintWeb? I was thinking that having separate reports for separate issues makes it easier for others to search them - better than to have them all in one issue report as comments.

          Show
          Mihai Sucan added a comment - Thanks Helen! Great! Then maybe Olli could report the issues he finds in this tracker for PaintWeb? I was thinking that having separate reports for separate issues makes it easier for others to search them - better than to have them all in one issue report as comments.
          Hide
          Helen Foster added a comment -

          You're right Mihai, separate issues would be helpful. Let's try and keep this issue to the subject title, so I'm going to keep quiet from now on

          Show
          Helen Foster added a comment - You're right Mihai, separate issues would be helpful. Let's try and keep this issue to the subject title, so I'm going to keep quiet from now on
          Hide
          Anthony Borrow added a comment -

          Mihai - It sounds like have a component in the tracker may be helpful to you. That way Olli and others who wish to create or report any issues, feature requests, etc. can do so through the Moodle tracker (now that GSOC is completed). By all means, feel free to create whatever issues you need. I have set you as the component lead so that those issues will automatically be assigned to you. For now, I have created the Patch: Paintweb component (http://tracker.moodle.org/browse/CONTRIB/component/10531) on the CONTRIB side but once the code is officially in HEAD then we can create a component in the tracker's MDL project. Please do not hesitate to let me know if there is anything I can do or if you need anything. I am grateful for your continued work on improving PaintWeb and look forward to seeing it in Moodle 2.0 as a great example of what can happen with a GSOC project. Peace - Anthony

          Show
          Anthony Borrow added a comment - Mihai - It sounds like have a component in the tracker may be helpful to you. That way Olli and others who wish to create or report any issues, feature requests, etc. can do so through the Moodle tracker (now that GSOC is completed). By all means, feel free to create whatever issues you need. I have set you as the component lead so that those issues will automatically be assigned to you. For now, I have created the Patch: Paintweb component ( http://tracker.moodle.org/browse/CONTRIB/component/10531 ) on the CONTRIB side but once the code is officially in HEAD then we can create a component in the tracker's MDL project. Please do not hesitate to let me know if there is anything I can do or if you need anything. I am grateful for your continued work on improving PaintWeb and look forward to seeing it in Moodle 2.0 as a great example of what can happen with a GSOC project. Peace - Anthony
          Hide
          Mihai Sucan added a comment -

          Great. Thank you very much Anthony.

          Show
          Mihai Sucan added a comment - Great. Thank you very much Anthony.
          Hide
          Olli Savolainen added a comment -

          Sorry again for the ambiguousness of my bug report. I will try to be more specific with the earlier comments when I have a chance to check it out again. (It seemed to be relatively easy to break it so I thought I would give you pointers on what sorts of playing is still problematic and you would likely find them yourself - but I will try to present steps for reproducing them.)

          Further accessibility tips for the color picker that came up in another discussion (http://moodle.org/mod/forum/discuss.php?d=130005 ), though I do not have a specific suggestion to give you right now:

          http://wearecolorblind.com/patterns/picking-colors/

          Show
          Olli Savolainen added a comment - Sorry again for the ambiguousness of my bug report. I will try to be more specific with the earlier comments when I have a chance to check it out again. (It seemed to be relatively easy to break it so I thought I would give you pointers on what sorts of playing is still problematic and you would likely find them yourself - but I will try to present steps for reproducing them.) Further accessibility tips for the color picker that came up in another discussion ( http://moodle.org/mod/forum/discuss.php?d=130005 ), though I do not have a specific suggestion to give you right now: http://wearecolorblind.com/patterns/picking-colors/
          Hide
          Mihai Sucan added a comment -

          Hello again Olli!

          Don't worry about the bug reports (there's more than one ), take your time.

          Thanks for the tips about the color picker.

          Show
          Mihai Sucan added a comment - Hello again Olli! Don't worry about the bug reports (there's more than one ), take your time. Thanks for the tips about the color picker.
          Hide
          Martin Dougiamas added a comment -

          Unfortunately it is not looking likely this will make it into 2.0, sorry. It might, but 2.1 is more likely.

          Show
          Martin Dougiamas added a comment - Unfortunately it is not looking likely this will make it into 2.0, sorry. It might, but 2.1 is more likely.
          Hide
          Martín Langhoff added a comment -

          Hi MartinD! Last we worked on this, the code was in good shape for a merge into HEAD. Maybe we dropped the ball in actually merging it.

          Would be good to hear from Mihai whether he's got time to handle bugreports following a merge into HEAD, during the stabilisation towards the 2.0 release.

          If it's too late for v2.0, I'll coordinate with him and you to merge this right after the branch point.

          Show
          Martín Langhoff added a comment - Hi MartinD! Last we worked on this, the code was in good shape for a merge into HEAD. Maybe we dropped the ball in actually merging it. Would be good to hear from Mihai whether he's got time to handle bugreports following a merge into HEAD, during the stabilisation towards the 2.0 release. If it's too late for v2.0, I'll coordinate with him and you to merge this right after the branch point.
          Hide
          Mihai Sucan added a comment -

          What is the schedule for the release of Moodle 2.0?

          I think i could squeeze time for bug reports, if the paint tool code is merged into HEAD. The sooner the code is merged, the better.

          Show
          Mihai Sucan added a comment - What is the schedule for the release of Moodle 2.0? I think i could squeeze time for bug reports, if the paint tool code is merged into HEAD. The sooner the code is merged, the better.
          Hide
          Mihai Sucan added a comment -

          Given the time constrains and that I have a lot of work to do for Mozilla, I would appreciate if someone else would volunteer to take PaintWeb integration forward into Moodle 2.

          PaintWeb now runs well in MSIE 9, as I expected when I wrote the code, without any important changes in the code. It would be perfect timing for further work on PaintWeb and for Moodle integration.

          Show
          Mihai Sucan added a comment - Given the time constrains and that I have a lot of work to do for Mozilla, I would appreciate if someone else would volunteer to take PaintWeb integration forward into Moodle 2. PaintWeb now runs well in MSIE 9, as I expected when I wrote the code, without any important changes in the code. It would be perfect timing for further work on PaintWeb and for Moodle integration.
          Hide
          Jean-François Dragon added a comment -

          Like I ask on the HTML editor forum (http://moodle.org/mod/forum/discuss.php?d=181235) is there a roadmap for the release of this or is the last comment from Mihai mean this project is wayting for somebody completing the job before being abble to integrate officially PaintWeb to the core of Moodle?

          Thanks for the info... JF

          Show
          Jean-François Dragon added a comment - Like I ask on the HTML editor forum ( http://moodle.org/mod/forum/discuss.php?d=181235 ) is there a roadmap for the release of this or is the last comment from Mihai mean this project is wayting for somebody completing the job before being abble to integrate officially PaintWeb to the core of Moodle? Thanks for the info... JF
          Hide
          Mihai Sucan added a comment -

          Jean: yes, that is correct.

          Show
          Mihai Sucan added a comment - Jean: yes, that is correct.
          Hide
          Patrick Juhl added a comment -

          Hello everyone!

          I'm here to revive the paintweb editor project through its integration in moodle!

          Feel free to contact me if you have questions concerning this feature.

          Cheers

          Show
          Patrick Juhl added a comment - Hello everyone! I'm here to revive the paintweb editor project through its integration in moodle! Feel free to contact me if you have questions concerning this feature. Cheers
          Hide
          Patrick Juhl added a comment -

          Demo of paintweb in moodle 2.2.2+, vote for it and lets have it integrated in the next moodle release!

          Show
          Patrick Juhl added a comment - Demo of paintweb in moodle 2.2.2+, vote for it and lets have it integrated in the next moodle release!
          Hide
          Mihai Sucan added a comment -

          @Patrick: Thanks for your awesome work! I am looking forward to review your work.

          Show
          Mihai Sucan added a comment - @Patrick: Thanks for your awesome work! I am looking forward to review your work.
          Hide
          Jean-François Dragon added a comment -

          @Patrick: So you think it could be done for the 2.3 release on june 1st? It should be realy nice!

          Show
          Jean-François Dragon added a comment - @Patrick: So you think it could be done for the 2.3 release on june 1st? It should be realy nice!
          Hide
          Patrick Juhl added a comment - - edited

          That would be awesome! But unfortunately, it is a bit late for that. I think it'll be for the following release!

          Still, I'm not very familiar with how to coordinate such work with the moodle developers though; so I hope to raise enough interest on this features so that they'll give me some guidelines to follow in order to contribute with this.

          Show
          Patrick Juhl added a comment - - edited That would be awesome! But unfortunately, it is a bit late for that. I think it'll be for the following release! Still, I'm not very familiar with how to coordinate such work with the moodle developers though; so I hope to raise enough interest on this features so that they'll give me some guidelines to follow in order to contribute with this.
          Hide
          Martin Dougiamas added a comment -

          I'd love to see this in Moodle - has anybody been using this? Can they review it?

          Show
          Martin Dougiamas added a comment - I'd love to see this in Moodle - has anybody been using this? Can they review it?
          Hide
          Helen Foster added a comment -

          Here's a link to a discussion about PaintWeb started by Patrick: http://moodle.org/mod/forum/discuss.php?d=201929

          Show
          Helen Foster added a comment - Here's a link to a discussion about PaintWeb started by Patrick: http://moodle.org/mod/forum/discuss.php?d=201929
          Hide
          Jean-François Dragon added a comment -

          @Martin - We are working on the upgrade of our Moodle installation (1.9 to v 2.2). When it will be done, we will install and use PaintWeb in one of our project in the comming months. Then, I'll try to give more info of our experience.

          Show
          Jean-François Dragon added a comment - @Martin - We are working on the upgrade of our Moodle installation (1.9 to v 2.2). When it will be done, we will install and use PaintWeb in one of our project in the comming months. Then, I'll try to give more info of our experience.
          Hide
          Mihai Sucan added a comment -

          @Martin: Patrick showed strong interest in getting PaintWeb landed in Moodle. He has shown the needed technical skills to do this, being able to rebase the patches I have.

          However, as with anyone new in a codebase, I had to give him some guidance. I was able to assist him with PaintWeb and the Moodle glue logic. Unfortunately, I was not able to assist him with the recent changes in Moodle APIs (since 2.0 things changed).

          Patrick posted some questions in the forums and I don't know if he got answers. I would appreciate it if the Moodle developers could help Patrick get the last things done. I try my best to help him with what I know.

          Please let me know if there's anything I can help with.

          Show
          Mihai Sucan added a comment - @Martin: Patrick showed strong interest in getting PaintWeb landed in Moodle. He has shown the needed technical skills to do this, being able to rebase the patches I have. However, as with anyone new in a codebase, I had to give him some guidance. I was able to assist him with PaintWeb and the Moodle glue logic. Unfortunately, I was not able to assist him with the recent changes in Moodle APIs (since 2.0 things changed). Patrick posted some questions in the forums and I don't know if he got answers. I would appreciate it if the Moodle developers could help Patrick get the last things done. I try my best to help him with what I know. Please let me know if there's anything I can help with.
          Hide
          Jean-Michel Vedrine added a comment -

          Hello,
          For Paintweb integration, you need to look ASAP at all the new stuff integrated in master last week and today because now that tinyMCE plugins are supported as Moodle subplugins it's a lot easier to port a tinyMCE plugin to Moodle.
          See MDL-34875 and subtasks.
          Now all Moodle specifics tinyMCE plugins (emoticons, dragmath, media, spellchecker) are subplugins in master and IMHO paintweb need to be defined as a subplugin too.

          Show
          Jean-Michel Vedrine added a comment - Hello, For Paintweb integration, you need to look ASAP at all the new stuff integrated in master last week and today because now that tinyMCE plugins are supported as Moodle subplugins it's a lot easier to port a tinyMCE plugin to Moodle. See MDL-34875 and subtasks. Now all Moodle specifics tinyMCE plugins (emoticons, dragmath, media, spellchecker) are subplugins in master and IMHO paintweb need to be defined as a subplugin too.
          Hide
          Nicholas Koeppen added a comment -

          Hello Patrick,

          I was wondering where the current code is located and how I can help by testing and/or developing the Moodle integration necessary to get this ready. We are about to start work on upgrading an old 'drawing' question type we developed for Moodle 1.9 and would much rather see this implemented instead of developing our own custom code.

          Show
          Nicholas Koeppen added a comment - Hello Patrick, I was wondering where the current code is located and how I can help by testing and/or developing the Moodle integration necessary to get this ready. We are about to start work on upgrading an old 'drawing' question type we developed for Moodle 1.9 and would much rather see this implemented instead of developing our own custom code.

            People

            • Votes:
              23 Vote for this issue
              Watchers:
              15 Start watching this issue

              Dates

              • Created:
                Updated: