Moodle
  1. Moodle
  2. MDL-20179

Grade cell tooltip contains HTML tags

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.5
    • Fix Version/s: 1.9.8
    • Component/s: Gradebook
    • Labels:
      None
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      This is due to some incompatible code in two lines of the gradebook's Javascript.

        Gliffy Diagrams

          Activity

          Hide
          Michael Woods added a comment -

          The bug still appears to be showing when 'Static students column' is ticked.

          Show
          Michael Woods added a comment - The bug still appears to be showing when 'Static students column' is ticked.
          Hide
          Michael Woods added a comment -

          Sorry - I just saw the 'fix for 1.9.6' - I was testing latest 1.9.5+ build. Ignore my previous comment

          Show
          Michael Woods added a comment - Sorry - I just saw the 'fix for 1.9.6' - I was testing latest 1.9.5+ build. Ignore my previous comment
          Hide
          Helen Foster added a comment -

          Michael, thanks for testing.

          As the fix for this issue was committed on 28 August, it should have been included in last Wednesday's 1.9.5+. Reopening based on your comment.

          Show
          Helen Foster added a comment - Michael, thanks for testing. As the fix for this issue was committed on 28 August, it should have been included in last Wednesday's 1.9.5+. Reopening based on your comment.
          Hide
          Andrew Davis added a comment -

          While the current javascript doesnt break the tooltip set up the changes previously introduced for this issue don't seem to make sense. Changing
          var header_cell_region = YAHOO.util.Dom.getRegion(rows[rows.length-1].firstChild);
          to
          var header_cell_region = YAHOO.util.Dom.getRegion();
          just means header_cell_region will always equal false.

          Show
          Andrew Davis added a comment - While the current javascript doesnt break the tooltip set up the changes previously introduced for this issue don't seem to make sense. Changing var header_cell_region = YAHOO.util.Dom.getRegion(rows [rows.length-1] .firstChild); to var header_cell_region = YAHOO.util.Dom.getRegion(); just means header_cell_region will always equal false.
          Hide
          Andrew Davis added a comment -

          I have a fix for this. Waiting for 1.9.7 to be out the door before committing.

          Show
          Andrew Davis added a comment - I have a fix for this. Waiting for 1.9.7 to be out the door before committing.
          Hide
          Andrew Davis added a comment -

          committed.

          Show
          Andrew Davis added a comment - committed.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: