Moodle
  1. Moodle
  2. MDL-20188

Feedback causing slow retrival of scales in gradebook.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.5
    • Fix Version/s: 1.9.16
    • Component/s: Feedback
    • Labels:
      None
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      5518

      Description

      Getting this error:

      • line 263 of lib/grade/grade_scale.php: call to debugging()
      • line 121 of grade/edit/scale/index.php: call to grade_scale->is_used()

      Please notify the developer of module "feedback" that new function module_scale_used_anywhere() should be implemented.

      Put following function into /mod/feedback/lib.php and has fixed problem.

      /**

      • Checks if scale is being used by any instance of feedback
        *
      • This is used to find out if scale used anywhere
      • @param $scaleid int
      • @return boolean True if the scale is used by any forum
        */
        function feedback_scale_used_anywhere($scaleid) {

      if ($scaleid and record_exists('feedback', 'scale', -$scaleid))

      { return true; }

      else

      { return false; }

      }

      Regards,

      Troy

        Activity

        Hide
        Iker Cillero added a comment -

        Hi Troy,

        Looking for an answer to the debugging error you commented, I have found this bug.

        Does your patch fix the problem? If it does, maybe someone could update feedback with the patch on it.

        Anyway unless someone fixes this on a different way, we would use your patch Troy, thanks for the fix.

        Show
        Iker Cillero added a comment - Hi Troy, Looking for an answer to the debugging error you commented, I have found this bug. Does your patch fix the problem? If it does, maybe someone could update feedback with the patch on it. Anyway unless someone fixes this on a different way, we would use your patch Troy, thanks for the fix.
        Hide
        Troy Williams added a comment -

        Hi Doi,

        Yeah did solve problem. Sorry for taking so long to get back to you.

        Regards,

        Troy

        Show
        Troy Williams added a comment - Hi Doi, Yeah did solve problem. Sorry for taking so long to get back to you. Regards, Troy
        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this issue.

        We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

        If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

        Michael d;

        lqjjLKA0p6

        Show
        Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
        Hide
        Andreas Grabs added a comment -

        I now integrated it in CVS and my git "git://github.com/grabs/mod_feedback.git"
        Andreas

        Show
        Andreas Grabs added a comment - I now integrated it in CVS and my git "git://github.com/grabs/mod_feedback.git" Andreas

          People

          • Votes:
            4 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: