Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20210

DB auth plugin ends with own print_error() if no matching l/p (or l only for internal) is found

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.7, 1.8.9, 1.9.5
    • Fix Version/s: 1.9.10
    • Component/s: Authentication
    • Labels:
      None
    • Affected Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      Uhm...

      was asking to Howard at: http://moodle.org/mod/forum/discuss.php?d=131784 and, when looking at the db/auth.php plugin... I've detected that it has one (two in fact) ANNOYING print_error() if the login/password check fails.

      Other auth plugins haven't that at all. Expected behaviour is to return true/false only (without own printing and die) afaik. Can you imagine any reason for that? Seems that it's there since the beginning.

        Attachments

          Activity

            People

            Assignee:
            skodak Petr Skoda
            Reporter:
            stronk7 Eloy Lafuente (stronk7)
            Tester:
            Nobody
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              25/Oct/10