Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20320

PDFs are not displaying according to settings

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.9.5
    • Fix Version/s: 1.9.6
    • Component/s: Resource
    • Labels:
      None
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      In 1.9 PDFs are not displaying according to the settings.

      See http://moodle.org/mod/forum/discuss.php?d=132906#p581622 for details.

      In short, here are combinations and expectations:

      1) Same window, navigation = No ..... PDF should be called directly and it isn't.
      2) Same window, navigation = Yes, with Frame ..... PDF should appear in lower frame and it isn't.
      3) Same window, navigation = Yes, without Frame .... PDF should appear embedded and it is (this is what happens for above two as well)

      Apparently all that is needed is to remove $embedded = true but I'm not sure if that's 100% correct on all browsers. Can you review this and fix it?

        Attachments

        1. MDL-20320_fix_only_PDF.patch
          2 kB
        2. MDL-20320.patch
          6 kB
        3. MDL-20320-db-upgrade.patch
          2 kB
        4. MDL-20320-db-upgrade.patch
          2 kB
        5. MDL-20320-db-upgrade.patch
          4 kB
        6. MDL-20320-db-upgrade.patch
          2 kB
        7. MDL-20320-db-upgrade.patch
          2 kB
        8. MDL-20320-fix_PDF-add_notice.patch
          3 kB

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              dougiamas Martin Dougiamas
              Tester:
              Nobody
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              3 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                21/Oct/09