Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20320

PDFs are not displaying according to settings

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.9.5
    • Fix Version/s: 1.9.6
    • Component/s: Resource
    • Labels:
      None
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      In 1.9 PDFs are not displaying according to the settings.

      See http://moodle.org/mod/forum/discuss.php?d=132906#p581622 for details.

      In short, here are combinations and expectations:

      1) Same window, navigation = No ..... PDF should be called directly and it isn't.
      2) Same window, navigation = Yes, with Frame ..... PDF should appear in lower frame and it isn't.
      3) Same window, navigation = Yes, without Frame .... PDF should appear embedded and it is (this is what happens for above two as well)

      Apparently all that is needed is to remove $embedded = true but I'm not sure if that's 100% correct on all browsers. Can you review this and fix it?

        Gliffy Diagrams

        1. MDL-20320_fix_only_PDF.patch
          2 kB
          Jérôme Mouneyrac
        2. MDL-20320.patch
          6 kB
          Jérôme Mouneyrac
        3. MDL-20320-db-upgrade.patch
          2 kB
          Jérôme Mouneyrac
        4. MDL-20320-db-upgrade.patch
          2 kB
          Jérôme Mouneyrac
        5. MDL-20320-db-upgrade.patch
          4 kB
          Jérôme Mouneyrac
        6. MDL-20320-db-upgrade.patch
          2 kB
          Jérôme Mouneyrac
        7. MDL-20320-db-upgrade.patch
          2 kB
          Jérôme Mouneyrac
        8. MDL-20320-fix_PDF-add_notice.patch
          3 kB
          Jérôme Mouneyrac

          Issue Links

            Activity

            dougiamas Martin Dougiamas created issue -
            dougiamas Martin Dougiamas made changes -
            Field Original Value New Value
            Link This issue will be resolved by MDL-9659 [ MDL-9659 ]
            dougiamas Martin Dougiamas made changes -
            Link This issue is a clone of MDL-10230 [ MDL-10230 ]
            dougiamas Martin Dougiamas made changes -
            Link This issue has a non-specific relationship to MDL-10021 [ MDL-10021 ]
            jerome Jérôme Mouneyrac made changes -
            Attachment MDL-20320.patch [ 18418 ]
            jerome Jérôme Mouneyrac made changes -
            Attachment MDL-20320.patch [ 18420 ]
            jerome Jérôme Mouneyrac made changes -
            Attachment MDL-20320.patch [ 18418 ]
            jerome Jérôme Mouneyrac made changes -
            Attachment MDL-20320_fix_only_PDF.patch [ 18422 ]
            jerome Jérôme Mouneyrac made changes -
            Attachment MDL-20320-fix_PDF-add_notice.patch [ 18423 ]
            jerome Jérôme Mouneyrac made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            jerome Jérôme Mouneyrac made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            jerome Jérôme Mouneyrac made changes -
            Attachment MDL-20320-db-upgrade.patch [ 18475 ]
            jerome Jérôme Mouneyrac made changes -
            Attachment MDL-20320-db-upgrade.patch [ 18482 ]
            jerome Jérôme Mouneyrac made changes -
            Attachment MDL-20320-db-upgrade.patch [ 18483 ]
            jerome Jérôme Mouneyrac made changes -
            Attachment MDL-20320-db-upgrade.patch [ 18484 ]
            jerome Jérôme Mouneyrac made changes -
            Attachment MDL-20320-db-upgrade.patch [ 18486 ]
            jerome Jérôme Mouneyrac made changes -
            Status Reopened [ 4 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            QA Assignee stronk7
            jerome Jérôme Mouneyrac made changes -
            Link This issue has been marked as being related by MDL-20388 [ MDL-20388 ]
            timhunt Tim Hunt made changes -
            Resolution Fixed [ 1 ]
            Status Closed [ 6 ] Reopened [ 4 ]
            Assignee Jerome Mouneyrac [ jerome ] Tim Hunt [ timhunt ]
            timhunt Tim Hunt made changes -
            Status Reopened [ 4 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            dougiamas Martin Dougiamas made changes -
            Comment [ I did it already, right after I tested Jerome's checkin. Commented in dev chat and everything ;) ]
            dougiamas Martin Dougiamas made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            QA Assignee stronk7 nobody
            dougiamas Martin Dougiamas made changes -
            Workflow jira [ 33422 ] MDL Workflow [ 63112 ]
            dougiamas Martin Dougiamas made changes -
            Workflow MDL Workflow [ 63112 ] MDL Full Workflow [ 92335 ]

              People

              • Votes:
                3 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  21/Oct/09