Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-14679 META: DB layer 2.0
  3. MDL-20349

Drop find_sequence_name() function

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.0
    • 2.0
    • Database SQL/XMLDB
    • None
    • MOODLE_20_STABLE
    • MOODLE_20_STABLE
    • Moderate

      We have one find_sequence_name() method in database_manager that is there because we needed it in the adodb stuff, to find one sequence exclusively for Oracle. In fact only Oracle (ADObd) implements/uses it.

      So I think it's better if we drop it from public API. Only Oracle SQL generator needs to find, sometimes, the sequence name, and the method for doing that is already there, no need to expose it to the public.

      Proposal:

      Drop method from public API (database manager)
      Drop corresponding tests (ddl tests, xmldb tests)
      Drop ADOdb Oracle driver

      Thoughts?

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Nobody Nobody (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.