Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-14679 META: DB layer 2.0
  3. MDL-20349

Drop find_sequence_name() function

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Database SQL/XMLDB
    • Labels:
      None
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      We have one find_sequence_name() method in database_manager that is there because we needed it in the adodb stuff, to find one sequence exclusively for Oracle. In fact only Oracle (ADObd) implements/uses it.

      So I think it's better if we drop it from public API. Only Oracle SQL generator needs to find, sometimes, the sequence name, and the method for doing that is already there, no need to expose it to the public.

      Proposal:

      Drop method from public API (database manager)
      Drop corresponding tests (ddl tests, xmldb tests)
      Drop ADOdb Oracle driver

      Thoughts?

        Attachments

          Activity

            People

            • Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Tester:
              Nobody
              Participants:
              Component watchers:
              Jake Dallimore, Jun Pataleta, Ryan Wyllie
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                24/Nov/10