Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20366

<span class="label "> breaks validation in course home page

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.9.5
    • Fix Version/s: None
    • Component/s: Accessibility
    • Labels:
      None
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE

      Description

      When adding label in courses home page and formatting labels content with the editor, using XHTML valid tags such as h1, hr, p, etc breaks validation since they are inside a "span" tag. This makes almost impossible to create labels with both good format and valid XHTML, thus breaking accessibility.

      Possible workaround:

      • change the span tag with div.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              andreabix Andrea Bicciolo added a comment -

              Adding Eloy as watcher for commenting and triaging this issue.

              Andrea

              Show
              andreabix Andrea Bicciolo added a comment - Adding Eloy as watcher for commenting and triaging this issue. Andrea
              Hide
              skodak Petr Skoda added a comment -

              Fixed, thanks!

              Petr Skoda

              Show
              skodak Petr Skoda added a comment - Fixed, thanks! Petr Skoda
              Hide
              syxton Matthew Davidson added a comment -

              divs are block level elements. If you wish to use divs instead of spans you must give it the style property of display:inline. Otherwise when you try to indent the label nothing will happen. divs create a breakline and spans don't, so when you move right it adds a spacer image. Spans don't start on a new line, but div's do

              Show
              syxton Matthew Davidson added a comment - divs are block level elements. If you wish to use divs instead of spans you must give it the style property of display:inline. Otherwise when you try to indent the label nothing will happen. divs create a breakline and spans don't, so when you move right it adds a spacer image. Spans don't start on a new line, but div's do
              Hide
              syxton Matthew Davidson added a comment -

              this fix breaks indent for labels

              Show
              syxton Matthew Davidson added a comment - this fix breaks indent for labels
              Hide
              skodak Petr Skoda added a comment -

              This span was already changed to div in 2.0dev, I suppose we need to fix it there too.

              Show
              skodak Petr Skoda added a comment - This span was already changed to div in 2.0dev, I suppose we need to fix it there too.
              Hide
              syxton Matthew Davidson added a comment -

              is there a reason you didn't leave it as a div and just add display:inline to the label class stylesheet?

              Show
              syxton Matthew Davidson added a comment - is there a reason you didn't leave it as a div and just add display:inline to the label class stylesheet?
              Hide
              syxton Matthew Davidson added a comment -

              sorry, that came off wrong. Just wanted to know if adding display:inline to that class would fix both problems

              Show
              syxton Matthew Davidson added a comment - sorry, that came off wrong. Just wanted to know if adding display:inline to that class would fix both problems
              Hide
              skodak Petr Skoda added a comment -

              This reason is I did not have time to test it yet, sorry.

              Show
              skodak Petr Skoda added a comment - This reason is I did not have time to test it yet, sorry.
              Hide
              syxton Matthew Davidson added a comment -

              ah, I see...sorry

              Show
              syxton Matthew Davidson added a comment - ah, I see...sorry
              Hide
              salvetore Michael de Raadt added a comment -

              Thanks for reporting this issue.

              We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

              If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

              Michael d;

              lqjjLKA0p6

              Show
              salvetore Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
              Hide
              salvetore Michael de Raadt added a comment -

              I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

              Show
              salvetore Michael de Raadt added a comment - I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: