Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20367

Grade Scales - Currently, only integers can be specified as letter grade boundaries when creating a grade scale. Provide the ability to specify a real number.

    Details

    • Testing Instructions:
      Hide
      • Go to /grade/edit/letter/index.php
      • Edit the boundary for an A to be >= 93.25
      • Verify that the boundary is saved as 93.25
      • Turn on letter grades column for the user report
      • Create a manual grade item, and grade a user with "93.2"
      • Verify they get an A- on the user report
      • Change their grade to "93.25"
      • Verify they get an A on the user report
      • Change their grade to "93.3"
      • Verify they get an A on the user report
      Show
      Go to /grade/edit/letter/index.php Edit the boundary for an A to be >= 93.25 Verify that the boundary is saved as 93.25 Turn on letter grades column for the user report Create a manual grade item, and grade a user with "93.2" Verify they get an A- on the user report Change their grade to "93.25" Verify they get an A on the user report Change their grade to "93.3" Verify they get an A on the user report
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-20367-master

      Description

      When creating a grading scale, the letter grade boundary is chosen from a drop-down list box and only an integer can be chosen. For example. I chose 89% as the letter grade boundary for an A-. As a result, any grade over 89, example 89.1 displays as an A-. I want only an 89.5 or higher to display as an A-. I am requesting a way to specify any number as a letter grade boundary in addtion to the integer choices currently in the drop-down list box, example 89.49% as the letter grade boundary for A-. Perhaps a "combo-box" instead of a "drop-down list box" in the interface would work.

        Gliffy Diagrams

        1. grade_letter_20367_only.patch
          2 kB
          Huy Hoang
        2. grade_letter.patch
          6 kB
          Huy Hoang

          Issue Links

            Activity

            Hide
            tsala Helen Foster added a comment -

            Edwinna, thanks for your report, and thanks to everyone who has voted.

            Assigning to our gradebook expert, Andrew, and setting a fix version of DEV backlog as it is a suggested improvement.

            Show
            tsala Helen Foster added a comment - Edwinna, thanks for your report, and thanks to everyone who has voted. Assigning to our gradebook expert, Andrew, and setting a fix version of DEV backlog as it is a suggested improvement.
            Hide
            patrickthibaudeau Patrick Thibaudeau added a comment -

            I realize that this is a Moodle 1.9.5 issue in this tracking number.However, we have fixed this issue for Moodle 2.x and I was wondering if we have to create a new issue for Moodle 2.x and then add the fix. Obviously, we would like to see the fix in the core code as to not have to modify the files every time we upgrade. This seems to be a recurring issue in the forums. I have talked to many institutions who have recently moved to Moodle who require this fix. Please let me know were I can post the fix.

            Show
            patrickthibaudeau Patrick Thibaudeau added a comment - I realize that this is a Moodle 1.9.5 issue in this tracking number.However, we have fixed this issue for Moodle 2.x and I was wondering if we have to create a new issue for Moodle 2.x and then add the fix. Obviously, we would like to see the fix in the core code as to not have to modify the files every time we upgrade. This seems to be a recurring issue in the forums. I have talked to many institutions who have recently moved to Moodle who require this fix. Please let me know were I can post the fix.
            Hide
            aborrow Anthony Borrow added a comment -

            Patrick - If you have a patch file or have a Git repository with a branch with the fix feel free to post those here so that they might be considered and evaluated. Peace - Anthony

            Show
            aborrow Anthony Borrow added a comment - Patrick - If you have a patch file or have a Git repository with a branch with the fix feel free to post those here so that they might be considered and evaluated. Peace - Anthony
            Hide
            mood@coep jan added a comment -

            Is a text field in the place of drop down box sufficient or is it necessary to have text field and drop down box simultaneously? If both text field and drop down box are present then data from both elements gets inserted into the database. With only the text field element , a single insertion occurs.

            Show
            mood@coep jan added a comment - Is a text field in the place of drop down box sufficient or is it necessary to have text field and drop down box simultaneously? If both text field and drop down box are present then data from both elements gets inserted into the database. With only the text field element , a single insertion occurs.
            Hide
            uqat moodle support UQAT added a comment -

            I will like to know if the version 2.3 will solve this problem ?

            Show
            uqat moodle support UQAT added a comment - I will like to know if the version 2.3 will solve this problem ?
            Hide
            moosebarns1023 Richard Barnes added a comment -

            I am using version 2.1.4. I have just learned that Moodle will not automatically round up numerical grades to the next letter grade. Specifically, 92.5 is read by Moodle as a 92, not a 93. Therefore, according to our school's grade scale for letters, Moodle will give the student an A- (92), not an A (93). I got the grade to display as A by manually changing the final grade from 92.5 to 93.0.

            Is there a better solution than this manual solution?

            Show
            moosebarns1023 Richard Barnes added a comment - I am using version 2.1.4. I have just learned that Moodle will not automatically round up numerical grades to the next letter grade. Specifically, 92.5 is read by Moodle as a 92, not a 93. Therefore, according to our school's grade scale for letters, Moodle will give the student an A- (92), not an A (93). I got the grade to display as A by manually changing the final grade from 92.5 to 93.0. Is there a better solution than this manual solution?
            Hide
            andyjdavis Andrew Davis added a comment -

            This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

            For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

            Show
            andyjdavis Andrew Davis added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
            Hide
            mratcliff Marti Ratcliff added a comment -

            I was searching for information on this topic and was redirected here from a post that indicated that it was being closed and should be tracked under this post. The last post indicates that it is "up for grabs" at this point. Does anyone know if another developer has taken on this issue, and if so, where I could see the latest information? If no one has been assigned, does this issue need to be reported again so we can have someone look into it?

            Show
            mratcliff Marti Ratcliff added a comment - I was searching for information on this topic and was redirected here from a post that indicated that it was being closed and should be tracked under this post. The last post indicates that it is "up for grabs" at this point. Does anyone know if another developer has taken on this issue, and if so, where I could see the latest information? If no one has been assigned, does this issue need to be reported again so we can have someone look into it?
            Hide
            joshuarbholden Joshua Holden added a comment -

            The latest information is here; if you don't see it assigned to a developer then no one is currently working on it. Under the old system, every issue was assigned to a developer even if that developer wasn't actually working on it. The new system is supposed to be more realistic; issues are not assigned to developers unless the developers are actually working on the issue.

            I'm not a developer so I'm just guessing, but I think the best way to encourage someone to start working on that is to get people to vote for it — consider asking people at your institution to create Tracker accounts and vote for this issue. I would guess that most of them do not even know they can do that! If you report the issue again it won't result in a new developer getting assigned and it might result in the votes getting split, which will make it less likely that the issue will get worked on.

            Show
            joshuarbholden Joshua Holden added a comment - The latest information is here; if you don't see it assigned to a developer then no one is currently working on it. Under the old system, every issue was assigned to a developer even if that developer wasn't actually working on it. The new system is supposed to be more realistic; issues are not assigned to developers unless the developers are actually working on the issue. I'm not a developer so I'm just guessing, but I think the best way to encourage someone to start working on that is to get people to vote for it — consider asking people at your institution to create Tracker accounts and vote for this issue. I would guess that most of them do not even know they can do that! If you report the issue again it won't result in a new developer getting assigned and it might result in the votes getting split, which will make it less likely that the issue will get worked on.
            Hide
            sillyxone Huy Hoang added a comment - - edited

            attached is a patch that changes the form to use textbox instead of listbox so that decimal values can be entered (for Moodle 2.4.4). Note that I've also submitted the same patch to MDL-39692 as I had to fix that bug in order for this change to work.

            Show
            sillyxone Huy Hoang added a comment - - edited attached is a patch that changes the form to use textbox instead of listbox so that decimal values can be entered (for Moodle 2.4.4). Note that I've also submitted the same patch to MDL-39692 as I had to fix that bug in order for this change to work.
            Hide
            sillyxone Huy Hoang added a comment -

            attached "grade_letter_20367_only.patch" that changes the form only (re-submitted a separate patch to address MDL-39692).

            Somebody needs to coordinate this issue and MDL-39692, as the patch I submitted there is needed in order for this one to work (otherwise decimal values submitted by the new form will still be converted to integers).

            Show
            sillyxone Huy Hoang added a comment - attached "grade_letter_20367_only.patch" that changes the form only (re-submitted a separate patch to address MDL-39692 ). Somebody needs to coordinate this issue and MDL-39692 , as the patch I submitted there is needed in order for this one to work (otherwise decimal values submitted by the new form will still be converted to integers).
            Hide
            aborrow Anthony Borrow added a comment -

            From #mtmoot there is renewed interest in this. Actually there has been talk about using dropdowns in general. It would seem that this could be nicely handled by giving an option to type in the number and autofill with integers using AJAX. In the U.S. many teachers like to round so it would be nice to say that 89.5 and above is an A. Peace - Anthony

            Show
            aborrow Anthony Borrow added a comment - From #mtmoot there is renewed interest in this. Actually there has been talk about using dropdowns in general. It would seem that this could be nicely handled by giving an option to type in the number and autofill with integers using AJAX. In the U.S. many teachers like to round so it would be nice to say that 89.5 and above is an A. Peace - Anthony
            Hide
            aborrow Anthony Borrow added a comment -

            p.s. - It looks like the database is ready to handle decimals for the boundaries, we just have to modify the UI.

            Show
            aborrow Anthony Borrow added a comment - p.s. - It looks like the database is ready to handle decimals for the boundaries, we just have to modify the UI.
            Hide
            gbrewste Geoffrey Brewster added a comment -

            At the University of Illinois, we run several large courses, some with more than 1000 students. Being able to more precisely tell Moodle what you want done with the grades is especially important in those courses since it is not that easy to look at every grade and just override the 10% that need it (that is over 100 students at that point). Plus, there is really no reason that I can see why instructors should be restricted on the numbers they enter for grades by just a UI that really doesn't need to be there and is actually more cumbersome to use than just entering what you want. I have always wondered why there are dropdowns for entering grade limits and grades; they should all be done away with. Computers are really good at counting stuff and should be able to handle whatever number people want to type in.

            Show
            gbrewste Geoffrey Brewster added a comment - At the University of Illinois, we run several large courses, some with more than 1000 students. Being able to more precisely tell Moodle what you want done with the grades is especially important in those courses since it is not that easy to look at every grade and just override the 10% that need it (that is over 100 students at that point). Plus, there is really no reason that I can see why instructors should be restricted on the numbers they enter for grades by just a UI that really doesn't need to be there and is actually more cumbersome to use than just entering what you want. I have always wondered why there are dropdowns for entering grade limits and grades; they should all be done away with. Computers are really good at counting stuff and should be able to handle whatever number people want to type in.
            Hide
            justinlitalien Justin Litalien added a comment -

            Huzzah! There is a ticket on this! I've had two instructors ask me about this just today. Would love to see some momentum on this.

            I'm imagining the same logic that is used for the Assignment grading (replacing a dropdown menu with a text box) and the Quiz overall feedback (enter rating scales via decimals) would be applied here. Any coders out there up to the challenge?

            Show
            justinlitalien Justin Litalien added a comment - Huzzah! There is a ticket on this! I've had two instructors ask me about this just today. Would love to see some momentum on this. I'm imagining the same logic that is used for the Assignment grading (replacing a dropdown menu with a text box) and the Quiz overall feedback (enter rating scales via decimals) would be applied here. Any coders out there up to the challenge?
            Hide
            kang10fu Khari Kambon added a comment -

            We have two new instances using version 2.7 and see this is still an issue, so just commenting in hopes if seeing some momentum on resolving this.When you have letter grade standards like most educational institutions do, this letter grade opton is useless because of the discrepancies. I also second the vote for providing the same feature as assignment grade boundaries (no more select menus and instead use text boxes). It imagine it shouldn't be that difficult to do, right?

            Show
            kang10fu Khari Kambon added a comment - We have two new instances using version 2.7 and see this is still an issue, so just commenting in hopes if seeing some momentum on resolving this.When you have letter grade standards like most educational institutions do, this letter grade opton is useless because of the discrepancies. I also second the vote for providing the same feature as assignment grade boundaries (no more select menus and instead use text boxes). It imagine it shouldn't be that difficult to do, right?
            Hide
            damyon Damyon Wiese added a comment -

            Requesting a peer review on behalf of Huy.

            Mark McKay said they have been using this patch for a long time.

            Show
            damyon Damyon Wiese added a comment - Requesting a peer review on behalf of Huy. Mark McKay said they have been using this patch for a long time.
            Hide
            cibot CiBoT added a comment -

            Fails against automated checks.

            Checked MDL-20367 using repository: git://github.com/damyon/moodle.git

            More information about this report

            Show
            cibot CiBoT added a comment - Fails against automated checks. Checked MDL-20367 using repository: git://github.com/damyon/moodle.git master (branch: MDL-20367-master | CI Job ) Coding style problems found Testing instructions are missing. More information about this report
            Hide
            dougiamas Martin Dougiamas added a comment -

            How did this not get a peer review before now? Look at the votes please.

            Show
            dougiamas Martin Dougiamas added a comment - How did this not get a peer review before now? Look at the votes please.
            Hide
            lazydaisy Mary Evans added a comment -

            Probably because everyone is busy working on other trivial stuff like User Menus!

            Show
            lazydaisy Mary Evans added a comment - Probably because everyone is busy working on other trivial stuff like User Menus!
            Hide
            lazydaisy Mary Evans added a comment -

            The patch needs updating as the one Damyon added is way too old and things have moved on since then.

            Show
            lazydaisy Mary Evans added a comment - The patch needs updating as the one Damyon added is way too old and things have moved on since then.
            Hide
            lazydaisy Mary Evans added a comment -

            I managed to test this out...so what I said before was because I had created the branch incorrectly.
            Anyway it works.

            Show
            lazydaisy Mary Evans added a comment - I managed to test this out...so what I said before was because I had created the branch incorrectly. Anyway it works.
            Hide
            damyon Damyon Wiese added a comment -

            Rebased.

            Show
            damyon Damyon Wiese added a comment - Rebased.
            Hide
            damyon Damyon Wiese added a comment -

            I'm looking at this now - there are problems with editing existing letters.

            Show
            damyon Damyon Wiese added a comment - I'm looking at this now - there are problems with editing existing letters.
            Hide
            damyon Damyon Wiese added a comment -

            Fixed the edit issue, sending for integration again.

            Show
            damyon Damyon Wiese added a comment - Fixed the edit issue, sending for integration again.
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated to master, thanks Huy Hoang/Damyon!

            Show
            poltawski Dan Poltawski added a comment - Integrated to master, thanks Huy Hoang/Damyon!
            Hide
            lameze Simey Lameze added a comment -

            Thanks Damyon, works as expected. Passing

            Show
            lameze Simey Lameze added a comment - Thanks Damyon, works as expected. Passing
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks for your efforts, this change is now upstream!

            It's not at all important to get it right the first time. It's vitally important to get it right the last time.
            – Andy Hunt & Dave Thomas

            Show
            poltawski Dan Poltawski added a comment - Thanks for your efforts, this change is now upstream! It's not at all important to get it right the first time. It's vitally important to get it right the last time. – Andy Hunt & Dave Thomas
            Hide
            tsala Helen Foster added a comment -

            I'm removing the qa_test_required label as this improvement now has a QA test - MDLQA-7629 master test and MDLQA-7630 in the current 2.8 cycle. Please comment if anything needs editing or adding to in the test.

            Show
            tsala Helen Foster added a comment - I'm removing the qa_test_required label as this improvement now has a QA test - MDLQA-7629 master test and MDLQA-7630 in the current 2.8 cycle. Please comment if anything needs editing or adding to in the test.
            Hide
            tsala Helen Foster added a comment -

            I'm removing the docs_required label as this improvement is now documented in https://docs.moodle.org/28/en/Grade_letters .

            Show
            tsala Helen Foster added a comment - I'm removing the docs_required label as this improvement is now documented in https://docs.moodle.org/28/en/Grade_letters .

              People

              • Votes:
                70 Vote for this issue
                Watchers:
                40 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Nov/14