Moodle
  1. Moodle
  2. MDL-20368

Assignment Grading - allow decimal values

    Details

    • Affected Branches:
      MOODLE_19_STABLE
    • Rank:
      5557

      Description

      When an assignment is created, a user can specify a numeric grade. When the assignment is graded, only integers appear in the drop-down list box. Example. I created an assignment worth 50 points. When I go to grade the assignment, my choices in the Grade drop-down list are 50/50, 49/50, 48/50, 47/50, etc. THere is no way to assign a 48.5 other than to go to the Gradebook which is a cumbersome way to do it. Grading within the assignment allows for email feedback, a larger feedback window and formatting options for feedback. I am requesting a way to assign a grade (perhaps in a combo box instead of a drop-down list box) that allows a user to type a real number in addition to choosing an integer from the grades listed.

      1. patch.txt
        48 kB
        jan
      2. patch.txt
        7 kB
        jan

        Issue Links

          Activity

          Hide
          Anthony Borrow added a comment -

          Edwinna - I remember this came up previously but I do not recall the response. My first thought is that it would require a bit of a change to the user interface as the dropdown list would not be practical with decimals. I want to say that there was a patch for this and this may be the best way to handle this. I do like the flexibility of being able to use decimals but would be interested in some of the previous discussions. I am not sure if you have the time to search through the forums and the tracker but it would be interesting to have some of the history here. Peace - Anthony

          Show
          Anthony Borrow added a comment - Edwinna - I remember this came up previously but I do not recall the response. My first thought is that it would require a bit of a change to the user interface as the dropdown list would not be practical with decimals. I want to say that there was a patch for this and this may be the best way to handle this. I do like the flexibility of being able to use decimals but would be interested in some of the previous discussions. I am not sure if you have the time to search through the forums and the tracker but it would be interesting to have some of the history here. Peace - Anthony
          Hide
          Mark Pearson added a comment -

          Why not have a box next to the dropdown list in which the user can enter a number, real or integer? This might be a lot more convenient for entering whole numbers than scrolling down a drop-down list anyway. Real numbers could be specified up to 5 decimal places even!

          Show
          Mark Pearson added a comment - Why not have a box next to the dropdown list in which the user can enter a number, real or integer? This might be a lot more convenient for entering whole numbers than scrolling down a drop-down list anyway. Real numbers could be specified up to 5 decimal places even!
          Hide
          Anthony Borrow added a comment -

          Mark - If I understand you correctly then there would be two options for the same thing and that from a user interface perspective tends to cause confusion. What happens if a select 90 from the dropdown box and then enter 89.4 in the other box - which has preference? As a result, we need to decide whether the convenience of the dropdown box is worth it or perhaps have an option per assignment as to how it will be graded (dropdown or textbox). Peace - Anthony

          Show
          Anthony Borrow added a comment - Mark - If I understand you correctly then there would be two options for the same thing and that from a user interface perspective tends to cause confusion. What happens if a select 90 from the dropdown box and then enter 89.4 in the other box - which has preference? As a result, we need to decide whether the convenience of the dropdown box is worth it or perhaps have an option per assignment as to how it will be graded (dropdown or textbox). Peace - Anthony
          Hide
          Mark Pearson added a comment -

          Anthony,
          I agree about the problems of having two options in the user interface – definitely not desireable. Personally, I find the drop-down box inconvenient for grading out of 100. It takes a lot more time to find the correct number than to type it in. Perhaps a course wide setting (number box or pull-down) that could be overridden by an assignment setting? Maybe this is too complex to start with, but certainly a setting per assignment would be useful. I think that anything that makes Moodle more flexible but without added complexity or user hassle is commendable. I may be nieve here but it strikes me that this amendment should not be too difficult to code, should it?

          Show
          Mark Pearson added a comment - Anthony, I agree about the problems of having two options in the user interface – definitely not desireable. Personally, I find the drop-down box inconvenient for grading out of 100. It takes a lot more time to find the correct number than to type it in. Perhaps a course wide setting (number box or pull-down) that could be overridden by an assignment setting? Maybe this is too complex to start with, but certainly a setting per assignment would be useful. I think that anything that makes Moodle more flexible but without added complexity or user hassle is commendable. I may be nieve here but it strikes me that this amendment should not be too difficult to code, should it?
          Hide
          Anthony Borrow added a comment -

          Mark - Personally my vote would be to just have the textbox. You can sort of use the dropdown and type in the number but it is not as nice as a textbox would be (IMHO). Peace - Anthony

          Show
          Anthony Borrow added a comment - Mark - Personally my vote would be to just have the textbox. You can sort of use the dropdown and type in the number but it is not as nice as a textbox would be (IMHO). Peace - Anthony
          Hide
          Edwinna Lucyk added a comment -

          Anthony - In Word, you can type a font size or choose one from a drop-down list. In Visual Basic, this type of form object is referred to as a combo box. It is a single object in the user interface that combines the ability of a drop-down list box and a text box. Is there anything like this in MOODLE?

          Show
          Edwinna Lucyk added a comment - Anthony - In Word, you can type a font size or choose one from a drop-down list. In Visual Basic, this type of form object is referred to as a combo box. It is a single object in the user interface that combines the ability of a drop-down list box and a text box. Is there anything like this in MOODLE?
          Hide
          Anthony Borrow added a comment -

          Edwinna - I am not aware of a combo box that function like that in Moodle; however, it would not surprise if there was not something similar through YUI. I did not see anything like that in Moodle's HTML QuickForm code but I was just taking a quick look. The code for the assignment module builds the HTML on its own for a simple select box with the choose_from_menu function defined in weblib.php. I do know that data validation is always one concern. I took a look at http://www.cs.tut.fi/~jkorpela/forms/combo.html which talks about combo boxes the implementations I saw there each raised concerns and none of them seemed like they would actually help the situation in Moodle as they either take up more screen real estate or require extra clicks. I suspect one of the full time developers would be able to comment more intelligently on combo boxes but these are my initial impressions. That said, keep the ideas coming as I am sure that working together we can come up with a way to improve things. We just want to be sure that we do so in ways that are sound and standards compliant. For a quick look at the W3C standards - even for HTML5 draft (http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#forms) I did not see anything that was combo box like but I may have missed something obvious. Let's keep the discussion going and see what we can find. You may also want to open it up for discussion in the assignment forum on Moodle.org to see what ideas folks have for improving it. Let me know how I can be of help. Peace - Anthony

          Show
          Anthony Borrow added a comment - Edwinna - I am not aware of a combo box that function like that in Moodle; however, it would not surprise if there was not something similar through YUI. I did not see anything like that in Moodle's HTML QuickForm code but I was just taking a quick look. The code for the assignment module builds the HTML on its own for a simple select box with the choose_from_menu function defined in weblib.php. I do know that data validation is always one concern. I took a look at http://www.cs.tut.fi/~jkorpela/forms/combo.html which talks about combo boxes the implementations I saw there each raised concerns and none of them seemed like they would actually help the situation in Moodle as they either take up more screen real estate or require extra clicks. I suspect one of the full time developers would be able to comment more intelligently on combo boxes but these are my initial impressions. That said, keep the ideas coming as I am sure that working together we can come up with a way to improve things. We just want to be sure that we do so in ways that are sound and standards compliant. For a quick look at the W3C standards - even for HTML5 draft ( http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#forms ) I did not see anything that was combo box like but I may have missed something obvious. Let's keep the discussion going and see what we can find. You may also want to open it up for discussion in the assignment forum on Moodle.org to see what ideas folks have for improving it. Let me know how I can be of help. Peace - Anthony
          Hide
          Louise Kelly (UNE) added a comment -

          I agree with Mark and Anthony that a simple decimal entry in a text box would be more user-friendly than the current drop-down, which is just clunky and unnecessarily time consuming. Educators must have the ability to apply decimal marks, especially in Higher Ed, where every jot and tittle counts for something. I see no point in having another field next to the existing drop-down, which would create redundancy and conflict. Please replace the drop-down system with something that can be used to apply a decimal mark.

          Show
          Louise Kelly (UNE) added a comment - I agree with Mark and Anthony that a simple decimal entry in a text box would be more user-friendly than the current drop-down, which is just clunky and unnecessarily time consuming. Educators must have the ability to apply decimal marks, especially in Higher Ed, where every jot and tittle counts for something. I see no point in having another field next to the existing drop-down, which would create redundancy and conflict. Please replace the drop-down system with something that can be used to apply a decimal mark.
          Hide
          jan added a comment -

          Please check our proposed patch , patch.txt for the changes . Instead of a drop down menu for grading ,a text area is provided for entering grade. Also we executed an alter table statement , "alter table mdl_assignment_submissions modify grade decimal(5,2);" to allow decimal values.
          Please review to see if the patch meets the required needs .

          Show
          jan added a comment - Please check our proposed patch , patch.txt for the changes . Instead of a drop down menu for grading ,a text area is provided for entering grade. Also we executed an alter table statement , "alter table mdl_assignment_submissions modify grade decimal(5,2);" to allow decimal values. Please review to see if the patch meets the required needs .
          Hide
          Gilles-Philippe Leblanc added a comment -

          Is there a patch for the 2.x version of Moodle?

          Show
          Gilles-Philippe Leblanc added a comment - Is there a patch for the 2.x version of Moodle?
          Hide
          jan added a comment -

          please delete our latest patch , patch.txt submitted on 26th march 2012 as it contains errors.

          Show
          jan added a comment - please delete our latest patch , patch.txt submitted on 26th march 2012 as it contains errors.
          Hide
          Anthony Borrow added a comment -

          Jan - No worries, we can all learn from the patch even if it has errors. Typically we do not delete files from the tracker unless there is some type of security issue (like accidentally including a personal password). That said, you can re-upload a corrected version of the same file and then the newer file will be the one that is available. If you still feel strongly that the file should be deleted just let me know. Peace - Anthony

          Show
          Anthony Borrow added a comment - Jan - No worries, we can all learn from the patch even if it has errors. Typically we do not delete files from the tracker unless there is some type of security issue (like accidentally including a personal password). That said, you can re-upload a corrected version of the same file and then the newer file will be the one that is available. If you still feel strongly that the file should be deleted just let me know. Peace - Anthony
          Hide
          Edwinna Lucyk added a comment -

          Some programming languages have a combo box object which allows users to choose from a drop-down list or type text. If MOODLE has something like that,users who need to type a decimal or just want to type the grade in can do so while those who want to use the drop-down list (and keep their hands on the mouse) can do that.

          Show
          Edwinna Lucyk added a comment - Some programming languages have a combo box object which allows users to choose from a drop-down list or type text. If MOODLE has something like that,users who need to type a decimal or just want to type the grade in can do so while those who want to use the drop-down list (and keep their hands on the mouse) can do that.
          Hide
          jan added a comment -

          We request you to please delete the patch submitted on 26th march as it contains errors and a lot of other changes which were not intended. Also, we will be uploading a new patch soon.

          Show
          jan added a comment - We request you to please delete the patch submitted on 26th march as it contains errors and a lot of other changes which were not intended. Also, we will be uploading a new patch soon.
          Hide
          yogeshrl added a comment -

          We just can't override the existing functionality of drop down list and provide the combobox or textfield to write decimal field. If we do so, then different scales created by the teacher like good, better, best etc, which are used by teacher to provide the grade while creating the assignment(grade- select drop down list box in assignment form) will not be functional at all, which makes no sense of creating the different scales for grading students. Also grade drop-down select box(assignment form) has no use. So we should have a good patch, which will incorporate all existing functionality and and new functionality to allow decimal fields also.

          Requirements...

          1) Patch will not override all existing functionality but provide decimal field along with existing scales also.
          2) When to choose the textbox to allow decimal point and drop down list(existing one) will depend on the scale selected by the teacher to grade student for the assignment (see assignment forms grade field).
          3) If Textbox is provided to allow decimal point, input validation must be performed on it on all possible cases like as we can enter anything in the textbox.
          cases..
          1) Any text
          2) decimal ranging from -infinity to +infinity
          3) integers
          Ex. selecting decimal value greater than the grade provided for the assignment.Ex. grade 60 select 78.5 as input

          Error reporting..
          If teacher provide the wrong grade to the student, error(message) should be reported on that student's row (In quickgrade) while quickgrading.
          While grading single user, if wrong grade is given, a proper message should be given on the same form.

          Hint..
          How will teacher come know what is the range of grades for this assignment. Hint in terms of help to teacher should be there.

          If any other requirements do you think then comment here. If I get any, will be posting.

          Show
          yogeshrl added a comment - We just can't override the existing functionality of drop down list and provide the combobox or textfield to write decimal field. If we do so, then different scales created by the teacher like good, better, best etc, which are used by teacher to provide the grade while creating the assignment(grade- select drop down list box in assignment form) will not be functional at all, which makes no sense of creating the different scales for grading students. Also grade drop-down select box(assignment form) has no use. So we should have a good patch, which will incorporate all existing functionality and and new functionality to allow decimal fields also. Requirements... 1) Patch will not override all existing functionality but provide decimal field along with existing scales also. 2) When to choose the textbox to allow decimal point and drop down list(existing one) will depend on the scale selected by the teacher to grade student for the assignment (see assignment forms grade field). 3) If Textbox is provided to allow decimal point, input validation must be performed on it on all possible cases like as we can enter anything in the textbox. cases.. 1) Any text 2) decimal ranging from -infinity to +infinity 3) integers Ex. selecting decimal value greater than the grade provided for the assignment.Ex. grade 60 select 78.5 as input Error reporting.. If teacher provide the wrong grade to the student, error(message) should be reported on that student's row (In quickgrade) while quickgrading. While grading single user, if wrong grade is given, a proper message should be given on the same form. Hint.. How will teacher come know what is the range of grades for this assignment. Hint in terms of help to teacher should be there. If any other requirements do you think then comment here. If I get any, will be posting.

            People

            • Votes:
              57 Vote for this issue
              Watchers:
              21 Start watching this issue

              Dates

              • Created:
                Updated: