Moodle
  1. Moodle
  2. MDL-20396

Extra HTML breaks assignment grading screen

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.5
    • Fix Version/s: 1.9.9
    • Component/s: Gradebook
    • Labels:
      None
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      31930

      Description

      When grading assignments, we've run into an issue that causes it to silently stop working and begin losing data. On the assignment grading screen, a user clicks "Update" for a specific student, assigns a grade, provides some feedback and then clicks either "Save changes" or "Save and show next" to continue. However, under certain conditions the data they enter doesn't appear on the main screen for the assignment. I've been able to replicate it when the feedback text is wrapped in a paragraph tag and the user puts a hard return at the end of the feedback. The resultant HTML looks something like this:

      <p>Feedback...</p>
      <p><br /></p>

      It appears that this problem only occurs when quick formatting is enabled, which causes me to speculate that the problem occurs when the editable comments field is being updated. When this occurs, it causes some other feedback entries to fail, even when they aren't formatted like this. Apparently something gets stuck as even going back to the problematic assignment and removing the last line of HTML doesn't always cause it to start working again.

      This is causing our instructors to lose data when they are moving through assignments with "Save and show next" and don't notice that the assignments aren't being updated in the background.

        Activity

        Hide
        Rossiani Wijaya added a comment -

        Hi Jason,

        Thank you for reporting the issue.

        The issue occurs when the content of feedback contain carriage return (\n).

        I created a patch to fix the issue and commit patch to 1.9stable distribution.

        Note: issue only occurs in version 1.9.

        Rosie.

        Show
        Rossiani Wijaya added a comment - Hi Jason, Thank you for reporting the issue. The issue occurs when the content of feedback contain carriage return (\n). I created a patch to fix the issue and commit patch to 1.9stable distribution. Note: issue only occurs in version 1.9. Rosie.
        Hide
        Petr Škoda added a comment -

        we are very close to release, moving the target, sorry...

        Show
        Petr Škoda added a comment - we are very close to release, moving the target, sorry...
        Hide
        Rossiani Wijaya added a comment -

        commit changes to 1.9_stable.

        Resolve.

        Show
        Rossiani Wijaya added a comment - commit changes to 1.9_stable. Resolve.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: