Moodle

Bulk User Action messages should allow use of HTML editor

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.6
  • Fix Version/s: 1.9.8
  • Component/s: HTML Editor, Messages, Usability
  • Labels:
    None

Description

Bulk User Action messages should allow using of editor if it is selected from Message settings in user profile - see http://moodle.org/mod/forum/discuss.php?d=134025

Changing one word 'textarea' to 'htmleditor' in admin/user/user_message_form.php line 12 should be enough to fix this.

  1. Text File
    20091124_MDL20402.patch
    24/Nov/09 3:03 PM
    0.8 kB
    Rossiani Wijaya
  2. Text File
    20091201_MDL20402_HEAD.patch
    01/Dec/09 10:00 AM
    1 kB
    Rossiani Wijaya
  3. File
    user_message_form.php
    01/Oct/09 1:21 PM
    0.7 kB
    Mauno Korpelainen

Issue Links

will be (partly) resolved by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-27823 Message - Messages sent with HTML editor during bulk message send displayed with HTML code

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Rossiani Wijaya added a comment -

Thanks Mauno for fixing the issue.

Created patch for this issue.

Show
Rossiani Wijaya added a comment - Thanks Mauno for fixing the issue. Created patch for this issue.
Hide
Permalink
Sam Hemelryk added a comment -

Hi guys,
Rossi the patch you have for 1.9 is fine, interestingly enough it was already formatting and delivering using FORMAT_HTML.
You will also however need to merge this to head which isn't quite so trivial.
When you have a moment I will run you through the new editor component.
Cheers
Sam

Show
Sam Hemelryk added a comment - Hi guys, Rossi the patch you have for 1.9 is fine, interestingly enough it was already formatting and delivering using FORMAT_HTML. You will also however need to merge this to head which isn't quite so trivial. When you have a moment I will run you through the new editor component. Cheers Sam
Hide
Permalink
Rossiani Wijaya added a comment -

Created patch to fix HTML editor in HEAD.

Show
Rossiani Wijaya added a comment - Created patch to fix HTML editor in HEAD.
Hide
Permalink
Sam Hemelryk added a comment -

Hi Rossi, both the 1.9 and 2.0 patch look good thank you.
My +1 for committing these but better check with Martin who I've added as a watcher on this issue

Show
Sam Hemelryk added a comment - Hi Rossi, both the 1.9 and 2.0 patch look good thank you. My +1 for committing these but better check with Martin who I've added as a watcher on this issue
Hide
Permalink
Martin Dougiamas added a comment -

+1 from me!

Show
Martin Dougiamas added a comment - +1 from me!
Hide
Permalink
Rossiani Wijaya added a comment -

committed to 1.9.8 and HEAD.

Show
Rossiani Wijaya added a comment - committed to 1.9.8 and HEAD.
Hide
Permalink
Helen Foster added a comment -

Hi Rosie,

Sorry to reopen this issue, however I can't get the html editor to work in the latest 1.9.7+ despite enabling html format for messages. On the user_bulk_message.php page moodle auto-format is selected by default and there is no html editor. Everything works fine in HEAD though!

PS Just changing the fix version of this issue to 1.9.8 only, as the instructions state "Do not include the current HEAD version unless it's the only one."

Show
Helen Foster added a comment - Hi Rosie, Sorry to reopen this issue, however I can't get the html editor to work in the latest 1.9.7+ despite enabling html format for messages. On the user_bulk_message.php page moodle auto-format is selected by default and there is no html editor. Everything works fine in HEAD though! PS Just changing the fix version of this issue to 1.9.8 only, as the instructions state "Do not include the current HEAD version unless it's the only one."
Hide
Permalink
Mauno Korpelainen added a comment -

Helen,

in addition to personal message settings (you need to have checked "Use HTML editor" there, not just enable HTML format ) check that you have not disabled editor from your user profile (When editing text -> use standard web forms / use HTML editor)

If you are using for example the Complete Windows package it has by default PHP eaccelerator enabled that might also cache changes - see for example http://moodle.org/mod/forum/discuss.php?d=131927#p619297

Show
Mauno Korpelainen added a comment - Helen, in addition to personal message settings (you need to have checked "Use HTML editor" there, not just enable HTML format ) check that you have not disabled editor from your user profile (When editing text -> use standard web forms / use HTML editor) If you are using for example the Complete Windows package it has by default PHP eaccelerator enabled that might also cache changes - see for example http://moodle.org/mod/forum/discuss.php?d=131927#p619297
Hide
Permalink
Helen Foster added a comment -

Mauno, thanks a lot for your help. I discovered that the reason for the lack of html editor was because I hadn't checked "Use HTML editor" in my message settings. Once I did so, the html editor displayed fine in 1.9.7+.

Rosie, thanks for fixing this issue and apologies for reopening it unnecessarily!

Show
Helen Foster added a comment - Mauno, thanks a lot for your help. I discovered that the reason for the lack of html editor was because I hadn't checked "Use HTML editor" in my message settings. Once I did so, the html editor displayed fine in 1.9.7+. Rosie, thanks for fixing this issue and apologies for reopening it unnecessarily!

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: