Moodle
  1. Moodle
  2. MDL-20402

Bulk User Action messages should allow use of HTML editor

    Details

    • Rank:
      31928

      Description

      Bulk User Action messages should allow using of editor if it is selected from Message settings in user profile - see http://moodle.org/mod/forum/discuss.php?d=134025

      Changing one word 'textarea' to 'htmleditor' in admin/user/user_message_form.php line 12 should be enough to fix this.

      1. 20091124_MDL20402.patch
        0.8 kB
        Rossiani Wijaya
      2. 20091201_MDL20402_HEAD.patch
        1 kB
        Rossiani Wijaya
      3. user_message_form.php
        0.7 kB
        Mauno Korpelainen

        Issue Links

          Activity

          Hide
          Rossiani Wijaya added a comment -

          Thanks Mauno for fixing the issue.

          Created patch for this issue.

          Show
          Rossiani Wijaya added a comment - Thanks Mauno for fixing the issue. Created patch for this issue.
          Hide
          Sam Hemelryk added a comment -

          Hi guys,
          Rossi the patch you have for 1.9 is fine, interestingly enough it was already formatting and delivering using FORMAT_HTML.
          You will also however need to merge this to head which isn't quite so trivial.
          When you have a moment I will run you through the new editor component.
          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi guys, Rossi the patch you have for 1.9 is fine, interestingly enough it was already formatting and delivering using FORMAT_HTML. You will also however need to merge this to head which isn't quite so trivial. When you have a moment I will run you through the new editor component. Cheers Sam
          Hide
          Rossiani Wijaya added a comment -

          Created patch to fix HTML editor in HEAD.

          Show
          Rossiani Wijaya added a comment - Created patch to fix HTML editor in HEAD.
          Hide
          Sam Hemelryk added a comment -

          Hi Rossi, both the 1.9 and 2.0 patch look good thank you.
          My +1 for committing these but better check with Martin who I've added as a watcher on this issue

          Show
          Sam Hemelryk added a comment - Hi Rossi, both the 1.9 and 2.0 patch look good thank you. My +1 for committing these but better check with Martin who I've added as a watcher on this issue
          Hide
          Martin Dougiamas added a comment -

          +1 from me!

          Show
          Martin Dougiamas added a comment - +1 from me!
          Hide
          Rossiani Wijaya added a comment -

          committed to 1.9.8 and HEAD.

          Show
          Rossiani Wijaya added a comment - committed to 1.9.8 and HEAD.
          Hide
          Helen Foster added a comment -

          Hi Rosie,

          Sorry to reopen this issue, however I can't get the html editor to work in the latest 1.9.7+ despite enabling html format for messages. On the user_bulk_message.php page moodle auto-format is selected by default and there is no html editor. Everything works fine in HEAD though!

          PS Just changing the fix version of this issue to 1.9.8 only, as the instructions state "Do not include the current HEAD version unless it's the only one."

          Show
          Helen Foster added a comment - Hi Rosie, Sorry to reopen this issue, however I can't get the html editor to work in the latest 1.9.7+ despite enabling html format for messages. On the user_bulk_message.php page moodle auto-format is selected by default and there is no html editor. Everything works fine in HEAD though! PS Just changing the fix version of this issue to 1.9.8 only, as the instructions state "Do not include the current HEAD version unless it's the only one."
          Hide
          Mauno Korpelainen added a comment -

          Helen,

          in addition to personal message settings (you need to have checked "Use HTML editor" there, not just enable HTML format ) check that you have not disabled editor from your user profile (When editing text -> use standard web forms / use HTML editor)

          If you are using for example the Complete Windows package it has by default PHP eaccelerator enabled that might also cache changes - see for example http://moodle.org/mod/forum/discuss.php?d=131927#p619297

          Show
          Mauno Korpelainen added a comment - Helen, in addition to personal message settings (you need to have checked "Use HTML editor" there, not just enable HTML format ) check that you have not disabled editor from your user profile (When editing text -> use standard web forms / use HTML editor) If you are using for example the Complete Windows package it has by default PHP eaccelerator enabled that might also cache changes - see for example http://moodle.org/mod/forum/discuss.php?d=131927#p619297
          Hide
          Helen Foster added a comment -

          Mauno, thanks a lot for your help. I discovered that the reason for the lack of html editor was because I hadn't checked "Use HTML editor" in my message settings. Once I did so, the html editor displayed fine in 1.9.7+.

          Rosie, thanks for fixing this issue and apologies for reopening it unnecessarily!

          Show
          Helen Foster added a comment - Mauno, thanks a lot for your help. I discovered that the reason for the lack of html editor was because I hadn't checked "Use HTML editor" in my message settings. Once I did so, the html editor displayed fine in 1.9.7+. Rosie, thanks for fixing this issue and apologies for reopening it unnecessarily!

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: