Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20441

Broken checkbox labels when using formslib's repeat_elements()

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 1.9.5
    • Fix Version/s: None
    • Component/s: Forms Library
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE

      Description

      When using the repeat_elements function in formslib, the labels accompanying checkboxes are broken. They all refer to the first checkbox element of the repeated set.

      Clicking on the checkbox square works, but clicking on the label doesn't.

      The reason for this is that all checkboxes get the same "id" attribute, so the labels all refer to the first object with that ID (at least in Firefox).

      I have attached a simple fix which solves the problem for me, but I'd like someone well-versed in formslib to review it as it might have some unexpected effects.

        Attachments

          Activity

            People

            Assignee:
            moodle.com moodle.com
            Reporter:
            francois Francois Marier
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: