Moodle
  1. Moodle
  2. MDL-20442

Average value calculation in Feedback's Multichoice item type is incorrect

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.9, 1.9.1, 1.9.2, 1.9.3, 1.9.4, 1.9.5
    • Fix Version/s: None
    • Component/s: Feedback
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Rank:
      2481

      Description

      The Feedback module's 'multichoicerated' item type appears to use an incorrect formula to calculate average response values - this occurs when optional questions are included in feedback but not all users provide an answer.

      When calculating the average for each question the module assumes it was answered by the total number of users that submitted a feedback response - regardless of whether they in fact they answered the individual question.

      I've added a screen shot that should hopefully help communicate the problem here - it shows a feedback which 4 users have provide a response - question 2 has been answered by all 4 users (which shows a correct average value). Question 1 however, has only been answered 3 times and shows an incorrect average - it should be calculated as follows:
      Question 1: (1x1) + (2x0) + (3x2) + (4x0) + (5x0) = 7 / 3 = 2.33 (correct)
      ... it appears to be calculated as follows:
      Question 1: (1x1) + (2x0) + (3x2) + (4x0) + (5x0) = 7 / 4 = 1.75 (incorrect)

      I've also attached a patch which should help fix this issue.

      Luke

      1. feedback-average.diff
        1 kB
        Luke Tucker
      1. FeedbackAverage.gif
        21 kB

        Activity

        Luke Tucker created issue -
        Martin Dougiamas made changes -
        Field Original Value New Value
        Workflow jira [ 33587 ] MDL Workflow [ 45430 ]
        Martin Dougiamas made changes -
        Workflow MDL Workflow [ 45430 ] MDL Full Workflow [ 73774 ]
        Dan Marsden made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Andreas Grabs [ grabs ] Dan Marsden [ danmarsden ]
        Resolution Won't Fix [ 2 ]

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: