Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.5
    • Fix Version/s: 2.0
    • Component/s: Accessibility, Blocks
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      The "List of categories" block contains a table with two columns: a category name and the number of courses in that category. There are no labels or column headings to help users understand what those columns represent.
      Why it matters

      Envisioning a table is much easier for sighted users than screen reader users.

      Possible solution

      The best solution would be to use a simple list, e.g.,

      • 4 courses in "Beginner"
      • 2 courses in "Prerequisites"

      This needs no additional labels or explanations, maintains a column layout, and is easier to read.

        Gliffy Diagrams

        1. 20100408_MDL-20459_HEAD.patch
          1 kB
          Rossiani Wijaya
        2. 20100414_MDL-20459_1.9.patch
          1 kB
          Rossiani Wijaya
        3. 20100624_MDL-20459_2.0.patch
          2 kB
          Rossiani Wijaya
        4. 20100722_MDL-20459b_2.0.patch
          7 kB
          Rossiani Wijaya
        5. section_code _mdl-20459.txt
          0.7 kB
          Rossiani Wijaya
        1. course_categories.png
          14 kB

          Issue Links

            Activity

            Hide
            dr.tech Larry M Elchuck, Ph.D. added a comment -

            I would even like to find a way to hack the code to place "number of courses" above that column, as in http://dl.getdropbox.com/u/2574249/Screenshots/2010-03-14_1107.png

            Show
            dr.tech Larry M Elchuck, Ph.D. added a comment - I would even like to find a way to hack the code to place "number of courses" above that column, as in http://dl.getdropbox.com/u/2574249/Screenshots/2010-03-14_1107.png
            Hide
            rwijaya Rossiani Wijaya added a comment -

            I made some layout changes to display category name and number of courses. The new layout combine category name and number courses into 1 column.

            Please refer to the screenshot for the new layout.

            Show
            rwijaya Rossiani Wijaya added a comment - I made some layout changes to display category name and number of courses. The new layout combine category name and number courses into 1 column. Please refer to the screenshot for the new layout.
            Hide
            dr.tech Larry M Elchuck, Ph.D. added a comment -

            I attempted your adaptation using the course/lib.php file in Moodle 1.9.8+ ..... $Id: lib.php,v 1.538.2.80 2010-02-25 10:16:15 stronk7 Exp $

            http://dl.getdropbox.com/u/2574249/Screenshots/2010-04-08_0731.png

            No output showed when the " echo $OUTPUT->spacer(array('height'=>10, 'width'=>$indent, 'br'=>true)); // should be done with CSS instead" line was used so I used the existing " print_spacer(10, $indent);" line instead.

            The output is as shown in the attached link ... notice that there is no subcategory indentation and the color is not changed.
            http://dl.getdropbox.com/u/2574249/Screenshots/2010-04-08_0739.png

            Thanks for your modification and help
            larry

            Show
            dr.tech Larry M Elchuck, Ph.D. added a comment - I attempted your adaptation using the course/lib.php file in Moodle 1.9.8+ ..... $Id: lib.php,v 1.538.2.80 2010-02-25 10:16:15 stronk7 Exp $ http://dl.getdropbox.com/u/2574249/Screenshots/2010-04-08_0731.png No output showed when the " echo $OUTPUT->spacer(array('height'=>10, 'width'=>$indent, 'br'=>true)); // should be done with CSS instead" line was used so I used the existing " print_spacer(10, $indent);" line instead. The output is as shown in the attached link ... notice that there is no subcategory indentation and the color is not changed. http://dl.getdropbox.com/u/2574249/Screenshots/2010-04-08_0739.png Thanks for your modification and help larry
            Hide
            ray Ray Lawrence added a comment -

            Hi Rosie,

            There is an underlying weakness in this approach I'm afraid. It's the assumption that organisations call Moodle courses "courses". In practice courses are given a variety of names, often more than one on the same site, depending upon how they are used. Forcing the use of the word course here (or whatever single alternative is substituted in lang editing) will diminish the flexibility and appeal of Moodle.

            Show
            ray Ray Lawrence added a comment - Hi Rosie, There is an underlying weakness in this approach I'm afraid. It's the assumption that organisations call Moodle courses "courses". In practice courses are given a variety of names, often more than one on the same site, depending upon how they are used. Forcing the use of the word course here (or whatever single alternative is substituted in lang editing) will diminish the flexibility and appeal of Moodle.
            Hide
            dr.tech Larry M Elchuck, Ph.D. added a comment -

            Great point Ray. Perhaps a generic term such as "offerings" could be used. I do like the idea of user-defined, as many will prefer to use "courses"

            Show
            dr.tech Larry M Elchuck, Ph.D. added a comment - Great point Ray. Perhaps a generic term such as "offerings" could be used. I do like the idea of user-defined, as many will prefer to use "courses"
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Hi Larry,

            Thank you reviewing the patch.

            The patch is used to fix version 2.0.

            the $OUTPUT->spacer function is implemented in version 2.0 and using it in 1.9.8 version will throw an error and skip the indentation output.

            Rosie

            Show
            rwijaya Rossiani Wijaya added a comment - Hi Larry, Thank you reviewing the patch. The patch is used to fix version 2.0. the $OUTPUT->spacer function is implemented in version 2.0 and using it in 1.9.8 version will throw an error and skip the indentation output. Rosie
            Hide
            dr.tech Larry M Elchuck, Ph.D. added a comment -

            Rosie
            Can there be an easy fix for the Moodle 1.9.8 version?
            Thanks
            larry

            Show
            dr.tech Larry M Elchuck, Ph.D. added a comment - Rosie Can there be an easy fix for the Moodle 1.9.8 version? Thanks larry
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Hi Larry,

            you should be able to use print_spacer function for 1.9.8 version. However, in order to use it properly, you might need to set the third parameter to 'false'.

            I created a new patch for 1.9.8. Please apply it to your version and let me know if it solve the issue.

            Thanks
            Rosie

            Show
            rwijaya Rossiani Wijaya added a comment - Hi Larry, you should be able to use print_spacer function for 1.9.8 version. However, in order to use it properly, you might need to set the third parameter to 'false'. I created a new patch for 1.9.8. Please apply it to your version and let me know if it solve the issue. Thanks Rosie
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Added Olli, Nick, Chetz and Leena as watchers.

            Your comments / feedback on this issue would be much appreciated.

            Thanks
            Rosie

            Show
            rwijaya Rossiani Wijaya added a comment - Added Olli, Nick, Chetz and Leena as watchers. Your comments / feedback on this issue would be much appreciated. Thanks Rosie
            Hide
            rwijaya Rossiani Wijaya added a comment -

            accessibility qa site is located at http://access.moodle.net/

            Show
            rwijaya Rossiani Wijaya added a comment - accessibility qa site is located at http://access.moodle.net/
            Hide
            dr.tech Larry M Elchuck, Ph.D. added a comment -

            Rosie

            Can you send me the section of code to paste into the lib file to test? I am not over proficient with the patch command

            Show
            dr.tech Larry M Elchuck, Ph.D. added a comment - Rosie Can you send me the section of code to paste into the lib file to test? I am not over proficient with the patch command
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Larry,

            Please take a look the text attachment for the section of code and let me know if it works for your 1.9 version.

            Show
            rwijaya Rossiani Wijaya added a comment - Larry, Please take a look the text attachment for the section of code and let me know if it works for your 1.9 version.
            Hide
            dr.tech Larry M Elchuck, Ph.D. added a comment -

            Hi Rosie

            Yes it works fine in 1.9.8+ (latest weekly).

            One small suggestion is to make the "- x Courses" italics and perhaps a font size smaller

            larry

            Show
            dr.tech Larry M Elchuck, Ph.D. added a comment - Hi Rosie Yes it works fine in 1.9.8+ (latest weekly). One small suggestion is to make the "- x Courses" italics and perhaps a font size smaller larry
            Hide
            dougiamas Martin Dougiamas added a comment -

            Sentences with numbers don't work well in all languages. More standard for the web would be:

            Category A (3)
            Category B (5)
            Category CCC (10)

            The numbers can have alt text (tooltip) with "number of courses" ...

            Show
            dougiamas Martin Dougiamas added a comment - Sentences with numbers don't work well in all languages. More standard for the web would be: Category A (3) Category B (5) Category CCC (10) The numbers can have alt text (tooltip) with "number of courses" ...
            Hide
            rwijaya Rossiani Wijaya added a comment -

            update patch to apply Martin's suggestion.

            Show
            rwijaya Rossiani Wijaya added a comment - update patch to apply Martin's suggestion.
            Hide
            dougiamas Martin Dougiamas added a comment -

            +1 for checkin

            Show
            dougiamas Martin Dougiamas added a comment - +1 for checkin
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Commit changes to moodle 2.0.

            Show
            rwijaya Rossiani Wijaya added a comment - Commit changes to moodle 2.0.

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  24/Nov/10