[MDL-20472] get_my_courses does not properly obey the limit parameter - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.9.5
Fix Version/s: 1.9.6
Component/s: Course, Dashboard (My home), Libraries
Labels:
None

Affected Branches:
MOODLE_19_STABLE
Fixed Branches:
MOODLE_19_STABLE

Description

get_my_courses always returns 2 more courses than specified in $limit (if available).

This is because of the way that it applied the limit.

It does it using a counter as it steps through the courses. In this process, there are two off by one error.

I have attached a diff that simplifies it somewhat (to read), and removes the two off by one errors.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

accesslib.diff
0.5 kB
08/Oct/09 8:45 AM
datalib.diff
0.5 kB
08/Oct/09 8:38 AM

Issue Links

will help resolve

MDL-19089 Ellipses incorrectly displayed for My Moodle page

Closed

MDL-13224 number of courses in MyMoodle home page

Reopened

Activity

People

Assignee:: Eric Merrill

Reporter:: Eric Merrill

Participants:: Andrew Davis, Eric Merrill, Martin Dougiamas

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 0 Start watching this issue

Dates

Created:: 08/Oct/09 8:38 AM

Updated:: 25/Nov/09 1:02 AM

Resolved:: 08/Oct/09 8:57 PM

Fix Release Date:: 21/Oct/09