"http://" content in "add link" text box can be confusing

The 'http://' prefix has been removed from the input box.

During submission, the system will detect user input and determine the needs to add 'http://' to the url.

Hi Rosie,

I've just checked the database of web links activity on our QA testing site http://qa.moodle.net/mod/data/edit.php?d=2 and found http:// in the URL field.

Hi Helen,

When creating a new url resource, the external link field is emtpy.

The http:// occurs on http://qa.moodle.net/mod/data/edit.php?d=2 because when the url was created the url field was not populated. Therefore, during submission, the system did not found the the existence of 'http;//' prefix in the url and append the prefix automatically to the url string before saving it to the database. since the link was save in the database containing http:// only, the url field in edit page is automatically populated with http:// string.

I modified the url_update_instance and url_add_instance functions to ignore adding the prefix when the field is empty.

attaching patch.

Helen,

My above comments was referring to "add a resource" -> "URL", which also has a tiny bug with submitting an empty url field. Somehow i stumbled back to add resources url while testing your posted link. oops.

Reviewing the "real" database of web links activity.

fix for database of web links activity:

• remove http:// prefix from input box
• added some code to check for the existence of http://, if it's not exist, it will add 'http://' prefix to the url.

The patch will fix database of web links activity page and add a resource" -> "URL" (from course page)

adding Sam to review the patch

accessibility qa site is located at http://access.moodle.net/mod/data/field.php?d=1

Hi Rossi

I've had a look at the patch you have posted, removing the default http:// is fine however there is a problem if the user enter a relative URL.
If we do want to add http:// we need to ensure that we are adding it only when required, either that or we ONLY allow fully qualified links.
Have a think about it and see what you can come up with.

Cheers
Sam

If it's /something then we need to leave it, and also if it's nntp:// or ftp://

So just add http:// when

• there is no :// in the string already, and
• the string doesn't start with /

update patch according to Martin's suggestion.

commit patch to 2.0