Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Questions
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      Tim Hunt in MDL-20522 comments
      By the way Pierre, I think you have broken 2 of the unit tests in HEAD. Can you try running the unit tests in the question folder, and see if they pass for you (Admin -> development -> unit tests, type 'question' into the text box then click run).
      Pierre Pichet in MDL-20522 next comment
      You are rigth, I just see this yesterday.
      I will have to correct the calls so that they reflect the actual code.
      On certain conditions $this->qtype->apply_unit return either a number or false
      $this->assertIdentical($this->qtype->apply_unit('1km', $units), false);
      $this->assertIdentical($this->qtype->apply_unit('1000 miles', array()), false);
      With the new code the conditions have changed.
      As a first step I will remove these two steps because they do not take account of all the new grading process so to not set "false alarm".
      then i will design a more complete testing procedure.

        Attachments

          Activity

            People

            Assignee:
            ppichet Pierre Pichet
            Reporter:
            ppichet Pierre Pichet
            Participants:
            Component watchers:
            Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: