Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20545

wrong translation of edit questions categories

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.9.5
    • 1.9.7
    • Quiz
    • None
    • any
    • MOODLE_19_STABLE
    • MOODLE_19_STABLE
    • Easy

    Description

      I just noticed that the tooltip for editing questions categories in the list of categories , and also the legend in editing a category incorrecty show 'edit this course category' and not 'edit this question category'.

      This is due to missing 'quiz' second parameter in get_string calls in category_class.php script

      ppollet@prope:~/web/moodle.195/question$ svn diff -rHEAD
      Index: category_class.php
      ===================================================================
      — category_class.php (révision 246)
      +++ category_class.php (copie de travail)
      @@ -62,7 +62,7 @@
      function set_icon_html($first, $last, &$lastitem){
      global $CFG;
      $category = $this->item;

      • $this->icons['edit']= $this->image_icon(get_string('editthiscategory'),
        + $this->icons['edit']= $this->image_icon(get_string('editthiscategory','quiz'), <--here
        "{$CFG->wwwroot}/question/category.php?".$this->parentlist->pageurl->get_query_string(array('edit'=>$category->id)), 'edit');
        parent::set_icon_html($first, $last, $lastitem);
        $toplevel = ($this->parentlist->parentitem === null);//this is a top level item
        @@ -148,7 +148,7 @@
        $this->str->delete = get_string('delete');
        $this->str->moveup = get_string('moveup');
        $this->str->movedown = get_string('movedown');
      • $this->str->edit = get_string('editthiscategory');
        + $this->str->edit = get_string('editthiscategory','quiz'); <--here
        $this->str->hide = get_string('hide');
        $this->str->publish = get_string('publish', 'quiz');
        $this->str->order = get_string('order');

      This also requires adding the missing translation string editthiscategory' in en_utf8/quiz.php and also in other langages

      Cheers.

      Attachments

        Activity

          People

            timhunt Tim Hunt
            ppollet Patrick Pollet
            Andrew Davis Andrew Davis
            Tim Hunt, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              25/Nov/09