Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20588

SCORM content issues in IE6 when zlib.output_compression enabled

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.5
    • Fix Version/s: 1.8.12, 1.9.8
    • Component/s: SCORM
    • Labels:
      None
    • Environment:
      Apache 2, PHP5, zlib.output_compression enabled
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE

      Description

      Several sites having problems loading SCORM content with zlib compression was enabled.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              dakota.duff Dakota Duff added a comment -

              Our tests show that adding the zlib.output_compression check from filelib.php to the tops of /mod/scorm/api.php and /mod/scorm/player.php fixes this.

              //IE compatibiltiy HACK!
              if (ini_get('zlib.output_compression'))

              { ini_set('zlib.output_compression', 'Off'); }
              Show
              dakota.duff Dakota Duff added a comment - Our tests show that adding the zlib.output_compression check from filelib.php to the tops of /mod/scorm/api.php and /mod/scorm/player.php fixes this. //IE compatibiltiy HACK! if (ini_get('zlib.output_compression')) { ini_set('zlib.output_compression', 'Off'); }
              Hide
              danmarsden Dan Marsden added a comment -

              Hi Dakota,

              I'm not too keen adding this as a global change to SCORM as it only affects specific Browsers. - any chance you could add a browser check, test and post a new patch?

              thanks,

              Dan

              Show
              danmarsden Dan Marsden added a comment - Hi Dakota, I'm not too keen adding this as a global change to SCORM as it only affects specific Browsers. - any chance you could add a browser check, test and post a new patch? thanks, Dan
              Hide
              dakota.duff Dakota Duff added a comment -

              Sure! This should only affect Internet Explorer.

              if (strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE') !== false && ini_get('zlib.output_compression') == 'On') {
                  ini_set('zlib.output_compression', 'Off');
              }

              Show
              dakota.duff Dakota Duff added a comment - Sure! This should only affect Internet Explorer. if (strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE') !== false && ini_get('zlib.output_compression') == 'On') { ini_set('zlib.output_compression', 'Off'); }
              Hide
              danmarsden Dan Marsden added a comment -

              thanks Dakota - that looks better, I've only seen this issue with IE 6, and thought it was resolved in newer versions of IE? - is that consistent with your testing?

              Show
              danmarsden Dan Marsden added a comment - thanks Dakota - that looks better, I've only seen this issue with IE 6, and thought it was resolved in newer versions of IE? - is that consistent with your testing?
              Hide
              danmarsden Dan Marsden added a comment -

              ..in which case can we use:

              strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE 6.')

              Show
              danmarsden Dan Marsden added a comment - ..in which case can we use: strpos($_SERVER ['HTTP_USER_AGENT'] , 'MSIE 6.')
              Hide
              danmarsden Dan Marsden added a comment -

              fix now in 1.8Stable, 1.9Stable and HEAD

              note - I have used the IE6 variation of this check - I have only seen this bug occur with IE 6 - I'm happy to modify it if other people can confirm this is a problem in newer versions (or older versions) of IE

              thanks for the report!

              Show
              danmarsden Dan Marsden added a comment - fix now in 1.8Stable, 1.9Stable and HEAD note - I have used the IE6 variation of this check - I have only seen this bug occur with IE 6 - I'm happy to modify it if other people can confirm this is a problem in newer versions (or older versions) of IE thanks for the report!

                People

                • Votes:
                  3 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Mar/10