Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20682

Closing a file handle which was never opened in process_email.php

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 1.9.7
    • 1.9.6, 1.9.7
    • General
    • None
    • MOODLE_19_STABLE
    • MOODLE_19_STABLE

    Description

      At the end of admin/process_email.php, fclose is called with $handle.

      $handle is never opened, $fd is.

      diff --git a/admin/process_email.php b/admin/process_email.php
      index 33c8783..f07e8c9 100755
      — a/admin/process_email.php
      +++ b/admin/process_email.php
      @@ -72,7 +72,7 @@ while(!feof($fd)) {

      $function($modargs,$body);

      -fclose($handle);
      +fclose($fd);

      Attachments

        Activity

          People

            poltawski Dan Poltawski
            dobedobedoh Andrew Lyons
            Rossiani Wijaya Rossiani Wijaya
            Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              21/Oct/09