Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20682

Closing a file handle which was never opened in process_email.php

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.9.7
    • Fix Version/s: 1.9.6, 1.9.7
    • Component/s: General
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      At the end of admin/process_email.php, fclose is called with $handle.

      $handle is never opened, $fd is.

      diff --git a/admin/process_email.php b/admin/process_email.php
      index 33c8783..f07e8c9 100755
      — a/admin/process_email.php
      +++ b/admin/process_email.php
      @@ -72,7 +72,7 @@ while(!feof($fd)) {

      $function($modargs,$body);

      -fclose($handle);
      +fclose($fd);

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            poltawski Dan Poltawski added a comment -

            Thanks for the patch, I've fixed this in CVS

            Show
            poltawski Dan Poltawski added a comment - Thanks for the patch, I've fixed this in CVS
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Resolved.

            Thanks everyone.

            Closing

            Show
            rwijaya Rossiani Wijaya added a comment - Resolved. Thanks everyone. Closing

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  21/Oct/09