Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20749

XMLDB editor: add a new field to table is broken

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Administration
    • Labels:
      None
    • Environment:
      MAMP
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      Go to xmldbeditor
      Load lib > Edit lib > Edit external_service > try to add a new field
      => blocker error message (Notice: Undefined variable: PAGE in /Users/jerome/Documents/Projects/Moodle_HEAD/moodle/admin/xmldb/actions/edit_field_save/edit_field_save.class.php on line 235)

      I debugged it in order to make it "work" for me but I'm not sure it's enough, so I didn't commit:

      admin/xmldb/..../edit_field_save.class.php:
      72: global $CFG, $XMLDB, $PAGE, $OUTPUT; //I added $PAGE and $GLOBAL

      admin/xmldb/index.php
      46: $PAGE->set_url('admin/xmldb/index.php'); //I added the line

      I also have this notice when I didn't put a correct length for the field :
      Notice: Undefined property: theme_config::$open_header_containers in /Users/jerome/Documents/Projects/Moodle_HEAD/moodle/lib/weblib.php on line 2707
      And some other error message appears somewhere else in xmldb editor that made me think these tmp fix are not that good

        Attachments

          Activity

            People

            • Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              jerome Jérôme Mouneyrac
              Tester:
              Nobody
              Participants:
              Component watchers:
              Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                24/Nov/10