XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Wiki (2.x)
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      1/ upgrade_mod_savepoint() not used, it should be in all official 2.0 plugins

      2/ $result should be replaced by exceptions

      3/ incorrect use of exceptions in many places - creating new general moodle_exception is always the last option, the exception type and details should give you more hints, it is not needed to localise upgrade problems usually

      4/ camel case not used in core moodle - NwikiMigrate()

      5/ I guess it would be more readable if each wiki had different directory - from my pov the only fully working has to be migration from the official 1.9x wiki

      6/ use DML recordsets when working with lots of data!

      7/ migration from ewiki not implemented yet, right?

        Attachments

          Activity

            People

            • Assignee:
              pigui Jordi Piguillem Poch
              Reporter:
              skodak Petr Skoda
              Tester:
              Nobody
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                24/Nov/10