Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20875

Popup bug when user logs in, is required to change passwords, AND has instant messages

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.7
    • Fix Version/s: 1.9.8
    • Component/s: Messages
    • Labels:
      None
    • Database:
      Any
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      Ok so when working on a recent issue I came across an pretty ugly bug in the login/messaging code.
      When a user who has an unread instant message logs in a popup is generated to inform the user that they have unread messages.
      However if the user is required to change their password both the main window and the popup are redirected to the change password screen.
      Probably just an reordering of the login code or something trivial... if no one wants this I'll look into it.

        Gliffy Diagrams

          Activity

          Hide
          rwijaya Rossiani Wijaya added a comment -

          Hi Sam,

          I created the patch for this bug. please take a look.

          thanks
          Rosie

          Show
          rwijaya Rossiani Wijaya added a comment - Hi Sam, I created the patch for this bug. please take a look. thanks Rosie
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Hey Rossi, nice and simple do you need to set $CFG->messaging back to its original value? I think because the script is ending there it probably does not need it.
          This can be committed when we are allowed to commit things again

          Show
          samhemelryk Sam Hemelryk added a comment - Hey Rossi, nice and simple do you need to set $CFG->messaging back to its original value? I think because the script is ending there it probably does not need it. This can be committed when we are allowed to commit things again
          Hide
          rwijaya Rossiani Wijaya added a comment -

          Sam - I reset $CFG->messaging back to its original value because it uses to trigger the message pop-up window to open after successfully changing the password. since we don't know whether there's any existing/waiting message for the user, I have to set it back to the original value.

          Show
          rwijaya Rossiani Wijaya added a comment - Sam - I reset $CFG->messaging back to its original value because it uses to trigger the message pop-up window to open after successfully changing the password. since we don't know whether there's any existing/waiting message for the user, I have to set it back to the original value.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Hi Rossi, commit your patch

          Show
          samhemelryk Sam Hemelryk added a comment - Hi Rossi, commit your patch

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Mar/10