Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Cannot Reproduce
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Unknown
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      722

      Description

      split is deprecated in php 5.3 and will be removed in php 6. It should be replaced with either explode or preg_split.

      1. MDL-20876-grep.txt
        11 kB
        Jonathan Harker
      2. split.txt
        605 kB
        Anthony Borrow

        Issue Links

          Activity

          Hide
          Anthony Borrow added a comment -

          uploading grep for split in contrib

          Show
          Anthony Borrow added a comment - uploading grep for split in contrib
          Hide
          Jonathan Harker added a comment -

          A grep of CVS HEAD shows some remaining split() calls. Most of them are easily replaced with explode() and some of the grep results are unrelated Javascript hits.

          Show
          Jonathan Harker added a comment - A grep of CVS HEAD shows some remaining split() calls. Most of them are easily replaced with explode() and some of the grep results are unrelated Javascript hits.
          Hide
          Anthony Borrow added a comment -

          Jonathan - With libraries especially those pulled in, I think the goal is to try to get those fixed upstream. I'm not sure what ought to be done to document Moodle-specific patches to things like Quickform and Alfresco (those were the commits that I noticed). Peace - Anthony

          Show
          Anthony Borrow added a comment - Jonathan - With libraries especially those pulled in, I think the goal is to try to get those fixed upstream. I'm not sure what ought to be done to document Moodle-specific patches to things like Quickform and Alfresco (those were the commits that I noticed). Peace - Anthony
          Hide
          Jonathan Harker added a comment -

          True, but updating core libraries with new versions this close to a release candidate is risky. Additionally, now we have some ammunition in the form of a commit or two we can point upstream maintainers to

          Show
          Jonathan Harker added a comment - True, but updating core libraries with new versions this close to a release candidate is risky. Additionally, now we have some ammunition in the form of a commit or two we can point upstream maintainers to
          Hide
          Anthony Borrow added a comment -

          Jonathan - Yep, I understand I would not update the core library at this point but just wanted to make sure that we were doing our part to do the pointing to those upstream. I just wanted to make sure we were following whatever our own best practices might be in such situations. Peace - Anthony

          Show
          Anthony Borrow added a comment - Jonathan - Yep, I understand I would not update the core library at this point but just wanted to make sure that we were doing our part to do the pointing to those upstream. I just wanted to make sure we were following whatever our own best practices might be in such situations. Peace - Anthony
          Hide
          Jonathan Harker added a comment -

          Fixed on HEAD. Should we be fixing these on MOODLE_19_STABLE?

          Show
          Jonathan Harker added a comment - Fixed on HEAD. Should we be fixing these on MOODLE_19_STABLE?
          Hide
          Anthony Borrow added a comment -

          Jonathan - I believe that Petr had indicated that only fatal errors (not warnings) would be addressed in 1.9. Peace - Anthony

          Show
          Anthony Borrow added a comment - Jonathan - I believe that Petr had indicated that only fatal errors (not warnings) would be addressed in 1.9. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          Actually I found the following from MDL-20876 - I see it mentions PHP 6 but I suspect a similar logic applies to the 5.3 deprecations:

          Andrew Davis added a comment - 08/Jul/10 05:00 PM
          Ok, marking this resolved. After discussion in the weekly developer meeting it was decided that php 6 support in the 1.9 branch isn't a priority.

          As Petr says the remaining instances of :alnum: are not in security related areas.

          Show
          Anthony Borrow added a comment - Actually I found the following from MDL-20876 - I see it mentions PHP 6 but I suspect a similar logic applies to the 5.3 deprecations: Andrew Davis added a comment - 08/Jul/10 05:00 PM Ok, marking this resolved. After discussion in the weekly developer meeting it was decided that php 6 support in the 1.9 branch isn't a priority. As Petr says the remaining instances of :alnum: are not in security related areas.
          Hide
          Andrew Davis added a comment - - edited

          Hi Jonathan and Anthony. Removing php functions that were deprecated in php 5.3 (and which will thus be removed in php 6) is indeed not a priority for MOODLE_19_STABLE. We've got to balance future proofing Moodle with the risk of regressions. Making such wide ranging changes to 1.9 seems like too much of a risk especially given that 2.0 is so close.

          Show
          Andrew Davis added a comment - - edited Hi Jonathan and Anthony. Removing php functions that were deprecated in php 5.3 (and which will thus be removed in php 6) is indeed not a priority for MOODLE_19_STABLE. We've got to balance future proofing Moodle with the risk of regressions. Making such wide ranging changes to 1.9 seems like too much of a risk especially given that 2.0 is so close.
          Hide
          Dan Poltawski added a comment -

          Closing this issue - not sure exactly when it was fixed, but they are all gone in core.

          Show
          Dan Poltawski added a comment - Closing this issue - not sure exactly when it was fixed, but they are all gone in core.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: