Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20910

link_to_popup_window conversion is buggy

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Libraries
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      Sorry to dump this on you Sam, but I don't have time to investigate it right now.

      Steps to reproduce: (there may be something easier than this, but this is the specific problem I noted)

      1. Create a quiz with adaptive mode = yes.
      2. Add a multiple choice question with several choices.
      3. preview the quiz, and select and submit several different answers to the question.
      4. Finally, click End test..., then submit all and finish.
      5. Look at the history table under the question, as it appears on the review page.
      6. Click the link of a previous state number. This will open in a pop-up window.

      Actual outcome:
      It just shows you the final state again.

      Expected outcome:
      It should show you the previous state.

      Analysis:
      Look closely at the URL. You will see we have an escaping problem. It will look something like

      .../mod/quiz/reviewquestion.php?attempt=2%3Fstate%3D5&question=1

      but it should be

      .../mod/quiz/reviewquestion.php?attempt=2&state=5&question=1

      Actually, very weird the way it escaped some = and &, but not all.

        Attachments

          Activity

            People

            • Assignee:
              samhemelryk Sam Hemelryk
              Reporter:
              timhunt Tim Hunt
              Tester:
              Nobody
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                24/Nov/10